mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Brian Gerst <brgerst@gmail.com>
Cc: Andy Lutomirski <luto@kernel.org>,
	the arch/x86 maintainers <x86@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"Christopherson, Sean J" <sean.j.christopherson@intel.com>
Subject: Re: [PATCH 0/2] Clean up x86_32 stackprotector
Date: Tue, 6 Oct 2020 10:32:05 +0200	[thread overview]
Message-ID: <20201006083205.GN2628@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <CAMzpN2j9h7FjpG_s_a09vKTCV+CYafjsKgK-k2RH7TG59FWz-w@mail.gmail.com>

On Mon, Oct 05, 2020 at 07:10:39PM -0400, Brian Gerst wrote:
> On Mon, Oct 5, 2020 at 3:30 PM Andy Lutomirski <luto@kernel.org> wrote:
> >
> > x86_32 stackprotector is a maintenance nightmare.  Clean it up.  This
> > disables stackprotector on x86_32 on GCC 8.1 and on all clang
> > versions -- I'll file a bug for the latter.
> 
> This should be doable on 64-bit too.  All that would need to be done
> is to remove the zero-base of the percpu segment (which would simplify
> alot of other code).

Like what?

I don't think it'd be hard to do, but I really don't see it doing
anything other than make things confusing as heck.

      reply	other threads:[~2020-10-06  8:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-05 19:30 Andy Lutomirski
2020-10-05 19:30 ` [PATCH 1/2] x86/stackprotector/32: Make the canary into a regular percpu variable Andy Lutomirski
2020-10-06  2:29   ` Sean Christopherson
2020-10-06  4:51     ` Andy Lutomirski
2020-10-06  8:26   ` Peter Zijlstra
2020-10-06 17:14   ` Brian Gerst
2020-10-07  1:16     ` Andy Lutomirski
2020-10-05 19:30 ` [PATCH 2/2] x86/entry/32: Remove leftover macros after stackprotector cleanups Andy Lutomirski
2020-10-06  8:34   ` Peter Zijlstra
2020-10-05 23:10 ` [PATCH 0/2] Clean up x86_32 stackprotector Brian Gerst
2020-10-06  8:32   ` Peter Zijlstra [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201006083205.GN2628@hirez.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=brgerst@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=sean.j.christopherson@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome