From: Steven Rostedt <rostedt@goodmis.org>
To: Wei Yang <richard.weiyang@linux.alibaba.com>
Cc: mingo@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/6] ftrace: replace do_for_each_ftrace_rec() with for_ftrace_rec_iter()
Date: Tue, 6 Oct 2020 10:42:17 -0400 [thread overview]
Message-ID: <20201006104217.005cec7c@gandalf.local.home> (raw)
In-Reply-To: <20200831031104.23322-6-richard.weiyang@linux.alibaba.com>
On Mon, 31 Aug 2020 11:11:03 +0800
Wei Yang <richard.weiyang@linux.alibaba.com> wrote:
> Now we have two similar infrastructure to iterate ftrace_page and
> dyn_ftrace:
>
> * do_for_each_ftrace_rec()
> * for_ftrace_rec_iter()
>
> The 2nd one, for_ftrace_rec_iter(), looks more generic, so preserve it
> and replace do_for_each_ftrace_rec() with it.
>
I also didn't pull in this patch. The reason is that the
for_ftrace_rec_iter() is specific for external usage (for archs to use) and
requires two function calls to do the iterations.
The do_for_each_ftrace_rec() is a faster, light weight version, but for
internal use only.
I rather keep both, as each has their own, but slightly different, use
cases.
-- Steve
next prev parent reply other threads:[~2020-10-06 14:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-31 3:10 [PATCH 0/6] ftrace: trivial cleanup Wei Yang
2020-08-31 3:10 ` [PATCH 1/6] ftrace: define seq_file only for FMODE_READ Wei Yang
2020-10-06 14:36 ` Steven Rostedt
2020-10-08 3:34 ` Wei Yang
2020-08-31 3:11 ` [PATCH 2/6] ftrace: use fls() to get the bits for dup_hash() Wei Yang
2020-08-31 3:11 ` [PATCH 3/6] ftrace: simplify the dyn_ftrace->flags macro Wei Yang
2020-08-31 3:11 ` [PATCH 4/6] ftrace: simplify the calculation of page number for ftrace_page->records Wei Yang
2020-08-31 3:11 ` [PATCH 5/6] ftrace: replace do_for_each_ftrace_rec() with for_ftrace_rec_iter() Wei Yang
2020-10-06 14:42 ` Steven Rostedt [this message]
2020-10-08 3:34 ` Wei Yang
2020-08-31 3:11 ` [PATCH 6/6] ftrace: ftrace_global_list is renamed to ftrace_ops_list Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201006104217.005cec7c@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=richard.weiyang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®