mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alex Elder <elder@linaro.org>
To: davem@davemloft.net, kuba@kernel.org
Cc: evgreen@chromium.org, subashab@codeaurora.org,
	cpratapa@codeaurora.org, bjorn.andersson@linaro.org,
	mka@chromium.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH net 0/2] net: ipa: non-setup bug fixes
Date: Tue,  6 Oct 2020 16:30:45 -0500	[thread overview]
Message-ID: <20201006213047.31308-1-elder@linaro.org> (raw)

This series fixes two bugs that occur if the IPA driver has not
completed its setup phase of initialization when an event occurs.

One event is the crash of the modem.  If the modem crashes,
ipa_modem_crashed() is called, and it performs various activities
intended to put the IPA hardware into a good state before the modem
reboots.  But if the IPA setup has not completed, resources used
for this cleanup will not be properly initialized.  So we must
skip doing this activity if we have not completed setup.

Similarly, if a system suspend is initiated but IPA setup has not
completed, the processing done in ipa_endpoint_suspend() should be
avoided.  And a subsequent system resume should also avoid resuming
endpoints that have not been initialized by IPA setup.

					-Alex

Alex Elder (2):
  net: ipa: only clear hardware state if setup has completed
  net: ipa: skip suspend/resume activities if not set up

 drivers/net/ipa/ipa_endpoint.c | 6 ++++++
 drivers/net/ipa/ipa_modem.c    | 3 +++
 2 files changed, 9 insertions(+)

-- 
2.20.1


             reply	other threads:[~2020-10-06 21:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-06 21:30 Alex Elder [this message]
2020-10-06 21:30 ` [PATCH net 1/2] net: ipa: only clear hardware state if setup has completed Alex Elder
2020-10-09 19:25   ` Jakub Kicinski
2020-10-09 19:39     ` Alex Elder
2020-10-09 19:41       ` Jakub Kicinski
2020-10-06 21:30 ` [PATCH net 2/2] net: ipa: skip suspend/resume activities if not set up Alex Elder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201006213047.31308-1-elder@linaro.org \
    --to=elder@linaro.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=cpratapa@codeaurora.org \
    --cc=davem@davemloft.net \
    --cc=evgreen@chromium.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mka@chromium.org \
    --cc=netdev@vger.kernel.org \
    --cc=subashab@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®