From: Masami Hiramatsu <mhiramat@kernel.org>
To: Tom Zanussi <zanussi@kernel.org>
Cc: rostedt@goodmis.org, axelrasmussen@google.com,
mhiramat@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 5/7] tracing: Add README information for synthetic_events file
Date: Thu, 8 Oct 2020 09:38:28 +0900 [thread overview]
Message-ID: <20201008093828.d9ac6e49299e0e4f79c349eb@kernel.org> (raw)
In-Reply-To: <3c7f178cf95aaeebc01eda7d95600dd937233eb7.1601848695.git.zanussi@kernel.org>
Hi Tom,
On Sun, 4 Oct 2020 17:14:07 -0500
Tom Zanussi <zanussi@kernel.org> wrote:
> Add an entry with a basic description of events/synthetic_events along
> with a simple example.
>
> Signed-off-by: Tom Zanussi <zanussi@kernel.org>
This looks good to me.
Reviewed-by: Masami Hiramatsu <mhiramat@kernel.org>
Thank you,
> ---
> kernel/trace/trace.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index 3f2533adae72..73fd0e0c0f39 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -5249,7 +5249,12 @@ static const char readme_msg[] =
> "\t trace(<synthetic_event>,param list) - generate synthetic event\n"
> "\t save(field,...) - save current event fields\n"
> #ifdef CONFIG_TRACER_SNAPSHOT
> - "\t snapshot() - snapshot the trace buffer\n"
> + "\t snapshot() - snapshot the trace buffer\n\n"
> +#endif
> +#ifdef CONFIG_SYNTH_EVENTS
> + " events/synthetic_events\t- Create/append/remove/show synthetic events\n"
> + "\t Write into this file to define/undefine new synthetic events.\n"
> + "\t example: echo 'myevent u64 lat; char name[]' >> synthetic_events\n"
> #endif
> #endif
> ;
> --
> 2.17.1
>
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2020-10-08 0:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-04 22:14 [PATCH v4 0/7] tracing: Add dynamic strings for synthetic events Tom Zanussi
2020-10-04 22:14 ` [PATCH v4 1/7] tracing: Change STR_VAR_MAX_LEN Tom Zanussi
2020-10-04 22:14 ` [PATCH v4 2/7] tracing: Fix parse_synth_field() error handling Tom Zanussi
2020-10-04 22:14 ` [PATCH v4 3/7] tracing: Save normal string variables Tom Zanussi
2020-10-04 22:14 ` [PATCH v4 4/7] tracing: Add support for dynamic strings to synthetic events Tom Zanussi
2020-10-08 9:22 ` Masami Hiramatsu
2020-10-08 19:21 ` Steven Rostedt
2020-10-09 11:15 ` Masami Hiramatsu
2020-10-08 20:33 ` Tom Zanussi
2020-10-04 22:14 ` [PATCH v4 5/7] tracing: Add README information for synthetic_events file Tom Zanussi
2020-10-08 0:38 ` Masami Hiramatsu [this message]
2020-10-04 22:14 ` [PATCH v4 6/7] selftests/ftrace: Add test case for synthetic event dynamic strings Tom Zanussi
2020-10-08 0:21 ` Masami Hiramatsu
2020-10-04 22:14 ` [PATCH v4 7/7] tracing: Change synthetic event string format to limit printed length Tom Zanussi
2020-10-05 22:17 ` Steven Rostedt
2020-10-07 14:24 ` Tom Zanussi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201008093828.d9ac6e49299e0e4f79c349eb@kernel.org \
--to=mhiramat@kernel.org \
--cc=axelrasmussen@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=zanussi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome