From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9B2AC433DF for ; Fri, 9 Oct 2020 11:50:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 98C812226B for ; Fri, 9 Oct 2020 11:50:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388235AbgJILuX (ORCPT ); Fri, 9 Oct 2020 07:50:23 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:56783 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732480AbgJILuX (ORCPT ); Fri, 9 Oct 2020 07:50:23 -0400 Received: from ip5f5af0a0.dynamic.kabel-deutschland.de ([95.90.240.160] helo=wittgenstein) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1kQquc-000710-Sn; Fri, 09 Oct 2020 11:50:14 +0000 Date: Fri, 9 Oct 2020 13:50:14 +0200 From: Christian Brauner To: Aleksa Sarai Cc: Alexander Viro , Shuah Khan , containers@lists.linux-foundation.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] openat2: reject RESOLVE_BENEATH|RESOLVE_IN_ROOT Message-ID: <20201009115014.ft7kjyejhqvommnv@wittgenstein> References: <20201007103608.17349-1-cyphar@cyphar.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201007103608.17349-1-cyphar@cyphar.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 07, 2020 at 09:36:08PM +1100, Aleksa Sarai wrote: > This was an oversight in the original implementation, as it makes no > sense to specify both scoping flags to the same openat2(2) invocation > (before this patch, the result of such an invocation was equivalent to > RESOLVE_IN_ROOT being ignored). > > This is a userspace-visible ABI change, but the only user of openat2(2) > at the moment is LXC which doesn't specify both flags and so no > userspace programs will break as a result. Indeed! > > Fixes: fddb5d430ad9 ("open: introduce openat2(2) syscall") > Signed-off-by: Aleksa Sarai > Acked-by: Christian Brauner > Cc: # v5.6+ > --- Thanks! This is a good fix imho. Christian