From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21A8FC433E7 for ; Fri, 9 Oct 2020 16:44:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C91052227F for ; Fri, 9 Oct 2020 16:44:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="sBWxx2zx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389853AbgJIQoy (ORCPT ); Fri, 9 Oct 2020 12:44:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388745AbgJIQoy (ORCPT ); Fri, 9 Oct 2020 12:44:54 -0400 Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70326C0613D2 for ; Fri, 9 Oct 2020 09:44:54 -0700 (PDT) Received: by mail-pg1-x544.google.com with SMTP id u24so7645375pgi.1 for ; Fri, 09 Oct 2020 09:44:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=cWs84SqTxwa8ama3NQBlgQfKzF7xkpWKH/ORsqiAAHY=; b=sBWxx2zxyXVDDqj7LQLC91NP4WZl2IijlnU1VqBHhEjONCt/4nRxelQ1SQKqfKfC4C SbNgzoUZMhd6kDzmFUk0FmaJPEcxF5BKg3A7JwRp0ImKTICk/5wqJCA+8ApTFJxXApIJ tHcxrL4RZT0/mVh4T6zIIBp4DyzH47aRcw7kriY37FvEziXScgPcnzvJCBAzKVbkYzZh UW82OrJ01LFM9U5e5Cu0A3z96WxEC6ElBI5T7Gq5CTIuOwonfD+o1sjv733jewFrP2MN dPCTFEeAvwPPxLyKfGYMtnT0DmTNW4f5NJUt4t8lq1sRoe/oseOc+6RJOK6PF6XU6T2y f7gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=cWs84SqTxwa8ama3NQBlgQfKzF7xkpWKH/ORsqiAAHY=; b=g1Dg2qK5CAjbb5mJb848zvM/pwOWAxj9eitszWBcpIFK2ndplrfwOfPPE4jXnRHb80 sx30RmNqI/Ck7kYj9PIHaIJeSSIm+GANI/4wblAeIhNVx/jw03Ixo+/Qssu28i8fgsNQ rKdpxxc+zZ1ebKvSLd4R8/OwtJrCAUXh5i6a9uVyDh6p+TopBxbgd7iPXGsAklmtvGNY P5yNgMc6Z/k3Ktmot3zVTgKz6eaTMjH3eYkqjA9sysH7yg52wNzRzDEzyHb5GKLkumVd jv66ggXIj0dFzh7aFSilL8FaY8TNUoIXcKTm2RebzIs230VyRHvbBNCXPP8sWKpYpuV8 s4nQ== X-Gm-Message-State: AOAM532JlsI6J/zd8eNyPI2nG2f+LMPv2dyLGfD2x+GuAuPgAEnVpG+N ziUWcXImo3hw0Pi6WkLbQdKa X-Google-Smtp-Source: ABdhPJztuoTLhqk/VCU2llwb2528WLSTViLzuMxU+lq9dIW2o4A7mCnwb/KC1X1moSIrnKipELTC1A== X-Received: by 2002:a62:1d57:0:b029:152:47a7:e04b with SMTP id d84-20020a621d570000b029015247a7e04bmr13233945pfd.48.1602261893875; Fri, 09 Oct 2020 09:44:53 -0700 (PDT) Received: from Mani-XPS-13-9360 ([2409:4072:6292:5a21:d5ff:f3e8:fcf2:ccc7]) by smtp.gmail.com with ESMTPSA id z21sm11602246pfr.43.2020.10.09.09.44.48 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 09 Oct 2020 09:44:53 -0700 (PDT) Date: Fri, 9 Oct 2020 22:14:45 +0530 From: Manivannan Sadhasivam To: Bhaumik Bhatt Cc: linux-arm-msm@vger.kernel.org, hemantk@codeaurora.org, jhugo@codeaurora.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 09/10] bus: mhi: core: Move to an error state on mission mode failure Message-ID: <20201009164445.GJ4810@Mani-XPS-13-9360> References: <1600480955-16827-1-git-send-email-bbhatt@codeaurora.org> <1600480955-16827-10-git-send-email-bbhatt@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1600480955-16827-10-git-send-email-bbhatt@codeaurora.org> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 18, 2020 at 07:02:34PM -0700, Bhaumik Bhatt wrote: > If the host receives a mission mode event and by the time it can get > to processing it, the register accesses fail implying a connectivity > error, MHI should move to an error state. This helps avoid longer wait > times from a synchronous power up perspective and accurately reflects > the MHI execution environment and power management states. > > Signed-off-by: Bhaumik Bhatt Reviewed-by: Manivannan Sadhasivam Thanks, Mani > --- > drivers/bus/mhi/core/pm.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/bus/mhi/core/pm.c b/drivers/bus/mhi/core/pm.c > index bce1f62..16c04ab 100644 > --- a/drivers/bus/mhi/core/pm.c > +++ b/drivers/bus/mhi/core/pm.c > @@ -384,10 +384,14 @@ static int mhi_pm_mission_mode_transition(struct mhi_controller *mhi_cntrl) > write_lock_irq(&mhi_cntrl->pm_lock); > if (MHI_REG_ACCESS_VALID(mhi_cntrl->pm_state)) > mhi_cntrl->ee = mhi_get_exec_env(mhi_cntrl); > - write_unlock_irq(&mhi_cntrl->pm_lock); > > - if (!MHI_IN_MISSION_MODE(mhi_cntrl->ee)) > + if (!MHI_IN_MISSION_MODE(mhi_cntrl->ee)) { > + mhi_cntrl->pm_state = MHI_PM_LD_ERR_FATAL_DETECT; > + write_unlock_irq(&mhi_cntrl->pm_lock); > + wake_up_all(&mhi_cntrl->state_event); > return -EIO; > + } > + write_unlock_irq(&mhi_cntrl->pm_lock); > > wake_up_all(&mhi_cntrl->state_event); > > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >