From: trix@redhat.com
To: dave@stgolabs.net, paulmck@kernel.org, josh@joshtriplett.org,
rostedt@goodmis.org, mathieu.desnoyers@efficios.com,
jiangshanlai@gmail.com, joel@joelfernandes.org,
natechancellor@gmail.com, ndesaulniers@google.com
Cc: linux-kernel@vger.kernel.org, rcu@vger.kernel.org,
clang-built-linux@googlegroups.com, Tom Rix <trix@redhat.com>
Subject: [PATCH] rcutorture: remove unneeded check
Date: Fri, 9 Oct 2020 12:47:36 -0700 [thread overview]
Message-ID: <20201009194736.2364-1-trix@redhat.com> (raw)
From: Tom Rix <trix@redhat.com>
clang static analysis reports this problem:
rcutorture.c:1999:2: warning: Called function pointer
is null (null dereference)
cur_ops->sync(); /* Later readers see above write. */
^~~~~~~~~~~~~~~
This is a false positive triggered by an earlier, later ignored
NULL check of sync() op. By inspection of the rcu_torture_ops,
the sync() op is never uninitialized. So this earlier check is
not needed.
Signed-off-by: Tom Rix <trix@redhat.com>
---
kernel/rcu/rcutorture.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c
index beba9e7963c8..6efc03a1d623 100644
--- a/kernel/rcu/rcutorture.c
+++ b/kernel/rcu/rcutorture.c
@@ -1989,7 +1989,7 @@ static void rcu_torture_fwd_prog_nr(struct rcu_fwd *rfp,
unsigned long stopat;
static DEFINE_TORTURE_RANDOM(trs);
- if (cur_ops->call && cur_ops->sync && cur_ops->cb_barrier) {
+ if (cur_ops->call && cur_ops->cb_barrier) {
init_rcu_head_on_stack(&fcs.rh);
selfpropcb = true;
}
--
2.18.1
next reply other threads:[~2020-10-09 19:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-09 19:47 trix [this message]
2020-10-09 20:18 ` Paul E. McKenney
2020-10-09 21:18 ` Tom Rix
2020-10-09 23:50 ` Paul E. McKenney
2020-10-10 0:24 ` Tom Rix
2020-10-10 2:57 ` Paul E. McKenney
2020-10-10 4:47 ` Tom Rix
2020-10-10 17:57 ` Paul E. McKenney
2020-10-10 18:07 ` Tom Rix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201009194736.2364-1-trix@redhat.com \
--to=trix@redhat.com \
--cc=clang-built-linux@googlegroups.com \
--cc=dave@stgolabs.net \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome