From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E98A1C433E7 for ; Sat, 10 Oct 2020 01:40:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7437B22226 for ; Sat, 10 Oct 2020 01:40:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729668AbgJJBjj (ORCPT ); Fri, 9 Oct 2020 21:39:39 -0400 Received: from netrider.rowland.org ([192.131.102.5]:47183 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1729436AbgJJBIT (ORCPT ); Fri, 9 Oct 2020 21:08:19 -0400 Received: (qmail 557695 invoked by uid 1000); 9 Oct 2020 21:08:17 -0400 Date: Fri, 9 Oct 2020 21:08:17 -0400 From: Alan Stern To: syzbot Cc: andreyknvl@google.com, ath9k-devel@qca.qualcomm.com, eli.billauer@gmail.com, gregkh@linuxfoundation.org, gustavoars@kernel.org, ingrassia@epigenesys.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, oneukum@suse.com, syzkaller-bugs@googlegroups.com, tiwai@suse.de Subject: Re: WARNING in hif_usb_send/usb_submit_urb Message-ID: <20201010010817.GA557391@rowland.harvard.edu> References: <20201010004944.GB557008@rowland.harvard.edu> <000000000000ef564605b1468771@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <000000000000ef564605b1468771@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 09, 2020 at 05:56:09PM -0700, syzbot wrote: > Hello, > > syzbot tried to test the proposed patch but the build/boot failed: Oops. One more try, with the typos fixed. #syz test: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git v5.9-rc8 Index: usb-devel/drivers/net/wireless/ath/ath9k/hif_usb.c =================================================================== --- usb-devel.orig/drivers/net/wireless/ath/ath9k/hif_usb.c +++ usb-devel/drivers/net/wireless/ath/ath9k/hif_usb.c @@ -1307,6 +1307,20 @@ static int ath9k_hif_usb_probe(struct us struct usb_device *udev = interface_to_usbdev(interface); struct hif_device_usb *hif_dev; int ret = 0; + struct usb_host_interface *alt; + struct usb_endpoint_descriptor *epd; + + /* Verify the expected endpoints are present */ + alt = interface->cur_altsetting; + if (!usb_find_int_in_endpoint(alt, &epd) || + usb_endpoint_num(epd) != USB_REG_IN_PIPE || + !usb_find_int_out_endpoint(alt, &epd) || + usb_endpoint_num(epd) != USB_REG_OUT_PIPE || + !usb_find_bulk_in_endpoint(alt, &epd) || + usb_endpoint_num(epd) != USB_WLAN_RX_PIPE || + !usb_find_bulk_out_endpoint(alt, &epd) || + usb_endpoint_num(epd) != USB_WLAN_TX_PIPE) + return -ENODEV; if (id->driver_info == STORAGE_DEVICE) return send_eject_command(interface);