From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F6BFC433E7 for ; Mon, 12 Oct 2020 07:02:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 244C62076E for ; Mon, 12 Oct 2020 07:02:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602486177; bh=GcaxG6AssIKJlRkw2n4E98BIOIcnPXPt35oIe/DLX04=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=hdwEhEB8br04+/7XEzHFCDDzHtzjicNAcUYKDgYfA77p+MjDJNNr9ccZMKLbam4c9 D6WAerBkGmGJuzlUKJERHz8nR+c6vNGuUFKkdFDZLJEcaF0y2v9hv/URtrmldzJjKc kk05UhiJnRc3loL4GfDlO0Gz7HBkkLkV9ExKbMMQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726620AbgJLHCx (ORCPT ); Mon, 12 Oct 2020 03:02:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726796AbgJLHCb (ORCPT ); Mon, 12 Oct 2020 03:02:31 -0400 Received: from mail-pf1-x442.google.com (mail-pf1-x442.google.com [IPv6:2607:f8b0:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 75BFDC0613D0 for ; Mon, 12 Oct 2020 00:02:30 -0700 (PDT) Received: by mail-pf1-x442.google.com with SMTP id j18so112544pfa.0 for ; Mon, 12 Oct 2020 00:02:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZnqrTrAcT/VOtU/CToYJH1aMkdkbU54lkaVpUGUxWv8=; b=SbndNsBSOWsCe2aa6ngCeSV+PsZP4lCEX6H7UvmMebcEwvKduO1tpXnrOsYBJpJfaK 2tqH0x/HdEueKn+WcN5gCiLrowduEdM/B6quaiMbXDNPOsKg5eV+EiVd3dwE99mitLK7 JJ4wZrv1QvLoVDQiExjpzSR4Luiwph/HdPunEwODRQQBxpr+THAtUAli7YU7t6gSaaBT rfyQLuzNSTadhSYsrnFyAmqpIeZa3FtUhwxvXWKjRVgSkx6kmri68y5CZ5nKqkzOaZwz t1pJqvaq+PSGwFp541JNM+07NUUND7K+h0EToaupitbhDydQ0J8+lE3HJrPWo4+7/Phm P3nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=ZnqrTrAcT/VOtU/CToYJH1aMkdkbU54lkaVpUGUxWv8=; b=XVuNwHppNi5UfUFBWjGFy1z4sRm48BFAqLy4yyhmX5rHH4HVnTbHtbVJQanIboLi2/ 4Cin9GEZUOJ8QHTHy19P5Y5L/lORU+hZ1mjqAwEwV5uO3XzDamrEe/iznUOpzLASwMba asjT0skXJDd3lCRwZzaazB3eC67q4OzezfgQ/1YuqYVx5MycOHZIatt2JUFh0z9bee3A DYqI2uJunoUSfpO1xAfpdLTdK/K3S4TeZ8vlk/uA2Dg4TwBPkQix3e2/t9xNscjElkoy g6+xAAO4yqTkU6Fp9tLMw/grlzeCvIedsRYKpBJgvgNwHJGUw67VG6pl+kN57qxW2mer TV5Q== X-Gm-Message-State: AOAM5313Y2NBqCJEwrLXcit4V5NaP8QWI32cYmWSt+KyqazBzg9h7bVe feORAgy+sH24fKFjCUR4kaQ= X-Google-Smtp-Source: ABdhPJyoPg0Y0hJGcB11OdgrYnCrhIBbGpDr9Xm1rxBNZHuLk4CQJtzv4LMFKBH0ssC8/tWgyhx9Hg== X-Received: by 2002:a17:90a:1704:: with SMTP id z4mr18176893pjd.7.1602486150065; Mon, 12 Oct 2020 00:02:30 -0700 (PDT) Received: from balhae.roam.corp.google.com ([112.159.19.5]) by smtp.gmail.com with ESMTPSA id n12sm18082556pgk.20.2020.10.12.00.02.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Oct 2020 00:02:29 -0700 (PDT) Sender: Namhyung Kim From: Namhyung Kim To: Arnaldo Carvalho de Melo , Jiri Olsa Cc: Ingo Molnar , Peter Zijlstra , Mark Rutland , Alexander Shishkin , LKML , Stephane Eranian , Ian Rogers Subject: [PATCH 3/6] perf inject: Enter namespace when reading build-id Date: Mon, 12 Oct 2020 16:02:11 +0900 Message-Id: <20201012070214.2074921-4-namhyung@kernel.org> X-Mailer: git-send-email 2.28.0.1011.ga647a8990f-goog In-Reply-To: <20201012070214.2074921-1-namhyung@kernel.org> References: <20201012070214.2074921-1-namhyung@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It should be in a proper mnt namespace when accessing the file. I think this had no problem since the build-id was actually read from map__load() -> dso__load() already. But I'd like to change it in the following commit. Acked-by: Jiri Olsa Signed-off-by: Namhyung Kim --- tools/perf/builtin-inject.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tools/perf/builtin-inject.c b/tools/perf/builtin-inject.c index 2c5e23d73a8a..670157db2502 100644 --- a/tools/perf/builtin-inject.c +++ b/tools/perf/builtin-inject.c @@ -23,6 +23,7 @@ #include "util/symbol.h" #include "util/synthetic-events.h" #include "util/thread.h" +#include "util/namespaces.h" #include #include @@ -419,16 +420,19 @@ static int perf_event__repipe_tracing_data(struct perf_session *session, static int dso__read_build_id(struct dso *dso) { + struct nscookie nsc; + if (dso->has_build_id) return 0; + nsinfo__mountns_enter(dso->nsinfo, &nsc); if (filename__read_build_id(dso->long_name, dso->build_id, sizeof(dso->build_id)) > 0) { dso->has_build_id = true; - return 0; } + nsinfo__mountns_exit(&nsc); - return -1; + return dso->has_build_id ? 0 : -1; } static int dso__inject_build_id(struct dso *dso, struct perf_tool *tool, -- 2.28.0.1011.ga647a8990f-goog