From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A6AEC433DF for ; Mon, 12 Oct 2020 08:37:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1DD0420714 for ; Mon, 12 Oct 2020 08:37:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726810AbgJLIhC (ORCPT ); Mon, 12 Oct 2020 04:37:02 -0400 Received: from jptosegrel01.sonyericsson.com ([124.215.201.71]:15638 "EHLO JPTOSEGREL01.sonyericsson.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726104AbgJLIhB (ORCPT ); Mon, 12 Oct 2020 04:37:01 -0400 X-Greylist: delayed 602 seconds by postgrey-1.27 at vger.kernel.org; Mon, 12 Oct 2020 04:37:01 EDT From: Peter Enderborg To: , Steven Rostedt , Ingo Molnar CC: Peter Enderborg Subject: [PATCH] trace: Return ENOTCONN instead of EBADF Date: Mon, 12 Oct 2020 10:26:42 +0200 Message-ID: <20201012082642.1394-1-peter.enderborg@sony.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain X-SEG-SpamProfiler-Analysis: v=2.3 cv=X8Is11be c=1 sm=1 tr=0 a=fZcToFWbXLKijqHhjJ02CA==:117 a=afefHYAZSVUA:10 a=z6gsHLkEAAAA:8 a=iexfoQ0RlwQR1pufzXEA:9 a=d-OLMTCWyvARjPbQ-enb:22 X-SEG-SpamProfiler-Score: 0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When there is no clients listening on event the trace return EBADF. The file is not a bad file descriptor and to get the userspace able to do a proper error handling it need a different error code that separate a bad file descriptor from a empty listening. Signed-off-by: Peter Enderborg --- kernel/trace/trace.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index d3e5de717df2..6e592bf736df 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c @@ -6651,8 +6651,8 @@ tracing_mark_write(struct file *filp, const char __user *ubuf, event = __trace_buffer_lock_reserve(buffer, TRACE_PRINT, size, irq_flags, preempt_count()); if (unlikely(!event)) - /* Ring buffer disabled, return as if not open for write */ - return -EBADF; + /* Ring buffer disabled, return as if not connected */ + return -ENOTCONN; entry = ring_buffer_event_data(event); entry->ip = _THIS_IP_; @@ -6731,8 +6731,8 @@ tracing_mark_raw_write(struct file *filp, const char __user *ubuf, event = __trace_buffer_lock_reserve(buffer, TRACE_RAW_DATA, size, irq_flags, preempt_count()); if (!event) - /* Ring buffer disabled, return as if not open for write */ - return -EBADF; + /* Ring buffer disabled, return not connected */ + return -ENOTCONN; entry = ring_buffer_event_data(event); -- 2.17.1