From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 102B7C43457 for ; Mon, 12 Oct 2020 10:38:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C0675208FE for ; Mon, 12 Oct 2020 10:38:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387696AbgJLKia (ORCPT ); Mon, 12 Oct 2020 06:38:30 -0400 Received: from elvis.franken.de ([193.175.24.41]:58432 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387604AbgJLKiT (ORCPT ); Mon, 12 Oct 2020 06:38:19 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1kRvDc-0008KW-08; Mon, 12 Oct 2020 12:38:16 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id E2460C1140; Mon, 12 Oct 2020 12:35:15 +0200 (CEST) Date: Mon, 12 Oct 2020 12:35:15 +0200 From: Thomas Bogendoerfer To: Tiezhu Yang Cc: Jonathan Corbet , Huacai Chen , Jiaxun Yang , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Xuefeng Li Subject: Re: [PATCH v2 2/4 RESEND] MIPS: Loongson64: Clean up numa.c Message-ID: <20201012103515.GB7953@alpha.franken.de> References: <1602373674-4579-1-git-send-email-yangtiezhu@loongson.cn> <1602373674-4579-3-git-send-email-yangtiezhu@loongson.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1602373674-4579-3-git-send-email-yangtiezhu@loongson.cn> User-Agent: Mutt/1.5.23 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 11, 2020 at 07:47:52AM +0800, Tiezhu Yang wrote: > (1) Replace nid_to_addroffset() with nid_to_addrbase() and then remove the > related useless code. > > (2) Since end_pfn = start_pfn + node_psize, use "node_psize" instead of > "end_pfn - start_pfn" to avoid the redundant calculation. > > (3) After commit 6fbde6b492df ("MIPS: Loongson64: Move files to the > top-level directory"), CONFIG_ZONE_DMA32 is always set for Loongson64 > due to MACH_LOONGSON64 selects ZONE_DMA32, so no need to use ifdef any > more, just remove it. > > Signed-off-by: Tiezhu Yang > Reviewed-by: Jiaxun Yang > --- > > v2: no changes, just add Reviewed-by tag > > arch/mips/include/asm/mach-loongson64/mmzone.h | 6 +----- > arch/mips/loongson64/numa.c | 29 +++----------------------- > 2 files changed, 4 insertions(+), 31 deletions(-) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]