From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8926C433DF for ; Mon, 12 Oct 2020 17:15:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6117920838 for ; Mon, 12 Oct 2020 17:15:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="NDA+CGbs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404001AbgJLRPz (ORCPT ); Mon, 12 Oct 2020 13:15:55 -0400 Received: from mail.skyhub.de ([5.9.137.197]:60966 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403845AbgJLRPy (ORCPT ); Mon, 12 Oct 2020 13:15:54 -0400 Received: from zn.tnic (p200300ec2f06920038fd325cadbd10b1.dip0.t-ipconnect.de [IPv6:2003:ec:2f06:9200:38fd:325c:adbd:10b1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 818291EC0354; Mon, 12 Oct 2020 19:15:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1602522953; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=SVEgQUKffP8ymr3h0zxoWDWJJBsuRqSGl9gDFBBQSfU=; b=NDA+CGbs6hMCkOIIkvx/sXos6ujKKZ2vXdDrA9UykAzBUirN7cAmWbV0ASSn7dpXnZLeEg 5HANlkTHvJmNbkDxfHa7bqs3dXTCtBqsyIzmm7X16di1i8iGMgz/+l6Lq/MBvP2DXV4GFh gp+P61p9eeDC2ySbIE5AIpvHDRM+RDw= Date: Mon, 12 Oct 2020 19:15:44 +0200 From: Borislav Petkov To: Joe Perches Cc: Andrew Morton , X86 ML , Andy Whitcroft , LKML , Peter Zijlstra Subject: Re: [PATCH -v4] checkpatch: Check for .byte-spelled insn opcodes documentation on x86 Message-ID: <20201012171544.GH22829@zn.tnic> References: <20201009161423.14583-1-bp@alien8.de> <20201010105421.GA24674@zn.tnic> <4147e49c0b1251343181b5580d946c2273247927.camel@perches.com> <20201010161112.GC24674@zn.tnic> <20201012142148.GA22829@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 12, 2020 at 10:09:44AM -0700, Joe Perches wrote: > From: Borislav Petkov > > Instruction opcode bytes spelled using the gas directive .byte should > carry a comment above them stating which binutils version has added > support for the instruction mnemonic so that they can be replaced with > the mnemonic when that binutils version is equal or less than the > minimum-supported version by the kernel. > > Add a check for that. > > Requested-by: Peter Zijlstra > Signed-off-by: Borislav Petkov > Signed-off-by: Joe Perches > --- > > v4: trivial neatening of $Hex_byte and adding a mechanism to > only emit the message once per patched file (Joe) > > scripts/checkpatch.pl | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) ./scripts/checkpatch.pl /tmp/test Global symbol "$rawline" requires explicit package name (did you forget to declare "my $rawline"?) at ./scripts/checkpatch.pl line 6943. Global symbol "$herecurr" requires explicit package name (did you forget to declare "my $herecurr"?) at ./scripts/checkpatch.pl line 6948. Execution of ./scripts/checkpatch.pl aborted due to compilation errors. No workie. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette