From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 739E7C433DF for ; Mon, 12 Oct 2020 18:04:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 369F22076D for ; Mon, 12 Oct 2020 18:04:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="yBJLGoVC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404140AbgJLSEa (ORCPT ); Mon, 12 Oct 2020 14:04:30 -0400 Received: from fllv0015.ext.ti.com ([198.47.19.141]:58592 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404138AbgJLSE1 (ORCPT ); Mon, 12 Oct 2020 14:04:27 -0400 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 09CI48q7055209; Mon, 12 Oct 2020 13:04:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1602525848; bh=ueTk+NXUctZm45WSAn64xT320s7C7sPFAPrludm8rhA=; h=From:To:CC:Subject:Date; b=yBJLGoVCIfUK24UfG/ogh6qS62wqpKEpkfU2yGmH4UpBS9toH/VjbT54px8KYAyb1 em3APbdkZYxCKSJs1bnSYD6RiM5QjcKyJJroMOHXHgK0SayH4DJouGHOnnrdaqcsql JJwqKLB1IjO0frGUf0hwQe40hPoeKETxrT1271Jg= Received: from DLEE112.ent.ti.com (dlee112.ent.ti.com [157.170.170.23]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 09CI481F100700 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 12 Oct 2020 13:04:08 -0500 Received: from DLEE110.ent.ti.com (157.170.170.21) by DLEE112.ent.ti.com (157.170.170.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Mon, 12 Oct 2020 13:04:08 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE110.ent.ti.com (157.170.170.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Mon, 12 Oct 2020 13:04:08 -0500 Received: from pratyush-OptiPlex-790.dhcp.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 09CI45j2021531; Mon, 12 Oct 2020 13:04:06 -0500 From: Pratyush Yadav To: Tudor Ambarus , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , , CC: Pratyush Yadav Subject: [PATCH 0/3] mtd: Make sure UBIFS does not do multi-pass page programming on flashes that don't support it Date: Mon, 12 Oct 2020 23:34:01 +0530 Message-ID: <20201012180404.6476-1-p.yadav@ti.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, The Cypress Semper S28 flash family uses 2-bit ECC by default. Under this ECC scheme, multi-pass page programs result in a program error. This means that unlike many other SPI NOR flashes, bit-walking cannot be done. In other words, once a page is programmed, its bits cannot then be flipped to 0 without an erase in between. This causes problems with UBIFS because it uses bit-walking to clear EC and VID magic numbers from a PEB before issuing an erase to preserve the file system correctness in case of power cuts. This series fixes that problem by introducing a flag MTD_NO_MULTI_PASS_WRITE that tells the file system layer that it can't do multi-pass writes. It also sets the writesize to the page size for such flashes to make sure file systems know that they should write the entire page in one go. It is based on the xSPI/8D series that adds support for Cypress S28 flash [0]. The patches themselves are independent of that series in the sense that they don't rely on 8D support. But since S28 flash is not supported without that series, these patches don't make much sense without it. Tested on Cypress S28HS512T and MT35XU512ABA on J7200 and J721E respectively. [0] https://lore.kernel.org/linux-mtd/20201005153138.6437-1-p.yadav@ti.com/ Pratyush Yadav (3): mtd: abi: Introduce MTD_NO_MULTI_PASS_WRITE UBI: Do not zero out EC and VID when multi-pass writes are not supported mtd: spi-nor: core: Introduce SPI_NOR_NO_MULTI_PASS_PP drivers/mtd/spi-nor/core.c | 5 +++++ drivers/mtd/spi-nor/core.h | 6 ++++++ drivers/mtd/spi-nor/spansion.c | 2 +- drivers/mtd/ubi/io.c | 2 +- include/uapi/mtd/mtd-abi.h | 1 + 5 files changed, 14 insertions(+), 2 deletions(-) -- 2.28.0