From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7ADFC433E7 for ; Mon, 12 Oct 2020 22:21:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8A63120797 for ; Mon, 12 Oct 2020 22:21:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="J/TNk3RO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389367AbgJLWVn (ORCPT ); Mon, 12 Oct 2020 18:21:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55774 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389008AbgJLWV3 (ORCPT ); Mon, 12 Oct 2020 18:21:29 -0400 Received: from mail-pf1-x44a.google.com (mail-pf1-x44a.google.com [IPv6:2607:f8b0:4864:20::44a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2A44C0613D0 for ; Mon, 12 Oct 2020 15:21:28 -0700 (PDT) Received: by mail-pf1-x44a.google.com with SMTP id 9so13495597pfj.22 for ; Mon, 12 Oct 2020 15:21:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:date:in-reply-to:message-id:mime-version:references:subject :from:to:cc; bh=2FPAJ4JOdoCzsWC2I93Vw1itU3Hyew78gghPY3DsZ34=; b=J/TNk3ROP2i9NV5ARtO1ok14A61R1Sg80iF+SLTzg/Y2GSueMy7/R1Mybj0K4q/eKP j8tqmHDAphmeDThQ1XJrwgDIGrRl45hVbeWulOsh9GPzdMbgo6MINccRoxBhfoRnGQr7 ATQz/SfDmvdTi3ZLxNjtWpBfLGEAEz+W/ANtM51fMq/AjVdC2mIsWX5NSo6XWWid2SVR X4fuqgCT5rNIST+KYNTBvo3Aw79QFU1kXh5UdpveLdVZz5YbljpeUkR+VCZoGeqItYrq K7JQ7Rhr6jl2bYYYNTiCd/hBjyjY1rd98VNs50mVLh2Us/aKsOX+a/apn3nqyPy+7cql jKKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=2FPAJ4JOdoCzsWC2I93Vw1itU3Hyew78gghPY3DsZ34=; b=Qsg8xSDokEcmTwti2Xqqx5steT6epzeN2O77+zORI0tPY98/o7F5dI+4nqHOO7U4Hv DQtoRxADZPsioE+t8tKf3jLGKzFMPM5Mpib2zdDUDDUh4/z+o3UznLnO0VJaFuqwTwT9 mAfE8B4RxQI4ySlcvgUW1sNA8BtzvMGup0T7XqiSafrqGsp32i4QugtrxPSw3gqv5TcM u7IYcPdxHZu1g285Tl32Ix+S+ELOU3v1YyoYFxKNwHEgAmYzpXQfFi0pfvfM4rirjG8i W0dLAeimEy4QfGG8H5tZ7BTobnYSrT6qMAc34DVEwf85gbBRTKDhwJXIXc4NgTsINtHF WcsA== X-Gm-Message-State: AOAM532v2DfChFrO9hTT67LX4+XmDET46/WYMsxDvzTfDqlrorfCaHkl UPuKuxMn9tMBQ0Fl0AtJCwcDDAjkCRWv2Q== X-Google-Smtp-Source: ABdhPJzne7N1vHKS4tz8oSTlt6o6aJQMscjj3GawvyrILDpXPgDbP8dhDhW/mzIbUhLC95qpouzc/tRuzHZTcg== Sender: "dlatypov via sendgmr" X-Received: from dlatypov.svl.corp.google.com ([2620:15c:2cd:202:a28c:fdff:fee3:28c6]) (user=dlatypov job=sendgmr) by 2002:a17:90a:f3d3:: with SMTP id ha19mr22246220pjb.58.1602541288393; Mon, 12 Oct 2020 15:21:28 -0700 (PDT) Date: Mon, 12 Oct 2020 15:20:44 -0700 In-Reply-To: <20201012222050.999431-1-dlatypov@google.com> Message-Id: <20201012222050.999431-7-dlatypov@google.com> Mime-Version: 1.0 References: <20201012222050.999431-1-dlatypov@google.com> X-Mailer: git-send-email 2.28.0.1011.ga647a8990f-goog Subject: [RFC v2 06/12] kunit: expose kunit_set_failure() for use by mocking From: Daniel Latypov To: dlatypov@google.com Cc: alan.maguire@oracle.com, brendanhiggins@google.com, davidgow@google.com, keescook@chromium.org, kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, mcgrof@kernel.org, sboyd@kernel.org, skhan@linuxfoundation.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Being able to fail the test outside of expectations and assertions is a requirement for new features, e.g. mocking, dynamic analysis, etc. Signed-off-by: Daniel Latypov --- include/kunit/test.h | 2 ++ lib/kunit/test.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/include/kunit/test.h b/include/kunit/test.h index 0eb3abb00da4..05330593243d 100644 --- a/include/kunit/test.h +++ b/include/kunit/test.h @@ -233,6 +233,8 @@ struct kunit { void kunit_init_test(struct kunit *test, const char *name, char *log); +void kunit_set_failure(struct kunit *test); + int kunit_run_tests(struct kunit_suite *suite); size_t kunit_suite_num_test_cases(struct kunit_suite *suite); diff --git a/lib/kunit/test.c b/lib/kunit/test.c index 4e8c74c89073..1ccf6dbecd73 100644 --- a/lib/kunit/test.c +++ b/lib/kunit/test.c @@ -15,7 +15,7 @@ #include "debugfs.h" #include "try-catch-impl.h" -static void kunit_set_failure(struct kunit *test) +void kunit_set_failure(struct kunit *test) { WRITE_ONCE(test->success, false); } -- 2.28.0.1011.ga647a8990f-goog