From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87633C43457 for ; Wed, 14 Oct 2020 10:25:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 16CF620848 for ; Wed, 14 Oct 2020 10:25:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728233AbgJNKZ4 (ORCPT ); Wed, 14 Oct 2020 06:25:56 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:46879 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726307AbgJNKZz (ORCPT ); Wed, 14 Oct 2020 06:25:55 -0400 X-Originating-IP: 93.34.118.233 Received: from uno.localdomain (93-34-118-233.ip49.fastwebnet.it [93.34.118.233]) (Authenticated sender: jacopo@jmondi.org) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 154E5E000A; Wed, 14 Oct 2020 10:25:51 +0000 (UTC) Date: Wed, 14 Oct 2020 12:29:53 +0200 From: Jacopo Mondi To: Niklas =?utf-8?Q?S=C3=B6derlund?= Cc: Jacopo Mondi , linux-renesas-soc@vger.kernel.org, geert+renesas@glider.be, laurent.pinchart@ideasonboard.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/6] arm64: dts: r8a779a0: Add VIN nodes Message-ID: <20201014102953.htcub73fxzyti6gn@uno.localdomain> References: <20201014094443.11070-1-jacopo+renesas@jmondi.org> <20201014094443.11070-7-jacopo+renesas@jmondi.org> <20201014101950.6imj3hql3cjb6fsv@oden.dyn.berto.se> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201014101950.6imj3hql3cjb6fsv@oden.dyn.berto.se> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Niklas, On Wed, Oct 14, 2020 at 12:19:50PM +0200, Niklas Söderlund wrote: > Hi Jacopo, > > Thanks for your work. > > On 2020-10-14 11:44:43 +0200, Jacopo Mondi wrote: > > Add VIN nodes to R8A779A0 R-Car V3U SoC. > > > > Signed-off-by: Jacopo Mondi > > --- > > arch/arm64/boot/dts/renesas/r8a779a0.dtsi | 320 ++++++++++++++++++++++ > > 1 file changed, 320 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi > > index 83962ad30a1d..bc81e6a761d3 100644 > > --- a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi > > +++ b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi > > @@ -105,6 +105,326 @@ scif0: serial@e6e60000 { > > status = "disabled"; > > }; > > > > + vin0: video@e6ef0000 { > > + compatible = "renesas,vin-r8a779a0"; > > How is this tested? There is no driver support and the schema you added Compile tested as specified in the cover letter > the compat string to mandates the 'renesas,id' property for the vin I was sure 'renesas,id' was BSP stuff 0_0 > nodes. As far as I can tell the reason for this id is gone with the new > pipeline of the V3U. So I guess as long as we don't break dtschema > validation all is good, just wanted to make sure ;-) > Do you think we should limit adding CPG clock entries only ? > > + reg = <0 0xe6ef0000 0 0x1000>; > > + interrupts = ; > > + clocks = <&cpg CPG_MOD 730>; > > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>; > > + resets = <&cpg 730>; > > + status = "disabled"; > > + }; > > + > > + vin1: video@e6ef1000 { > > + compatible = "renesas,vin-r8a779a0"; > > + reg = <0 0xe6ef1000 0 0x1000>; > > + interrupts = ; > > + clocks = <&cpg CPG_MOD 731>; > > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>; > > + resets = <&cpg 731>; > > + status = "disabled"; > > + }; > > + > > + vin2: video@e6ef2000 { > > + compatible = "renesas,vin-r8a779a0"; > > + reg = <0 0xe6ef2000 0 0x1000>; > > + interrupts = ; > > + clocks = <&cpg CPG_MOD 800>; > > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>; > > + resets = <&cpg 800>; > > + status = "disabled"; > > + }; > > + > > + vin3: video@e6ef3000 { > > + compatible = "renesas,vin-r8a779a0"; > > + reg = <0 0xe6ef3000 0 0x1000>; > > + interrupts = ; > > + clocks = <&cpg CPG_MOD 801>; > > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>; > > + resets = <&cpg 801>; > > + status = "disabled"; > > + }; > > + > > + vin4: video@e6ef4000 { > > + compatible = "renesas,vin-r8a779a0"; > > + reg = <0 0xe6ef4000 0 0x1000>; > > + interrupts = ; > > + clocks = <&cpg CPG_MOD 802>; > > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>; > > + resets = <&cpg 802>; > > + status = "disabled"; > > + }; > > + > > + vin5: video@e6ef5000 { > > + compatible = "renesas,vin-r8a779a0"; > > + reg = <0 0xe6ef5000 0 0x1000>; > > + interrupts = ; > > + clocks = <&cpg CPG_MOD 803>; > > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>; > > + resets = <&cpg 803>; > > + status = "disabled"; > > + }; > > + > > + vin6: video@e6ef6000 { > > + compatible = "renesas,vin-r8a779a0"; > > + reg = <0 0xe6ef6000 0 0x1000>; > > + interrupts = ; > > + clocks = <&cpg CPG_MOD 804>; > > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>; > > + resets = <&cpg 804>; > > + status = "disabled"; > > + }; > > + > > + vin7: video@e6ef7000 { > > + compatible = "renesas,vin-r8a779a0"; > > + reg = <0 0xe6ef7000 0 0x1000>; > > + interrupts = ; > > + clocks = <&cpg CPG_MOD 805>; > > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>; > > + resets = <&cpg 805>; > > + status = "disabled"; > > + }; > > + > > + vin8: video@e6ef8000 { > > + compatible = "renesas,vin-r8a779a0"; > > + reg = <0 0xe6ef8000 0 0x1000>; > > + interrupts = ; > > + clocks = <&cpg CPG_MOD 806>; > > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>; > > + resets = <&cpg 806>; > > + status = "disabled"; > > + }; > > + > > + vin9: video@e6ef9000 { > > + compatible = "renesas,vin-r8a779a0"; > > + reg = <0 0xe6ef9000 0 0x1000>; > > + interrupts = ; > > + clocks = <&cpg CPG_MOD 807>; > > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>; > > + resets = <&cpg 807>; > > + status = "disabled"; > > + }; > > + > > + vin10: video@e6efa000 { > > + compatible = "renesas,vin-r8a779a0"; > > + reg = <0 0xe6efa000 0 0x1000>; > > + interrupts = ; > > + clocks = <&cpg CPG_MOD 808>; > > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>; > > + resets = <&cpg 808>; > > + status = "disabled"; > > + }; > > + > > + vin11: video@e6efb000 { > > + compatible = "renesas,vin-r8a779a0"; > > + reg = <0 0xe6efb000 0 0x1000>; > > + interrupts = ; > > + clocks = <&cpg CPG_MOD 809>; > > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>; > > + resets = <&cpg 809>; > > + status = "disabled"; > > + }; > > + > > + vin12: video@e6efc000 { > > + compatible = "renesas,vin-r8a779a0"; > > + reg = <0 0xe6efc000 0 0x1000>; > > + interrupts = ; > > + clocks = <&cpg CPG_MOD 810>; > > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>; > > + resets = <&cpg 810>; > > + status = "disabled"; > > + }; > > + > > + vin13: video@e6efd000 { > > + compatible = "renesas,vin-r8a779a0"; > > + reg = <0 0xe6efd000 0 0x1000>; > > + interrupts = ; > > + clocks = <&cpg CPG_MOD 811>; > > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>; > > + resets = <&cpg 811>; > > + status = "disabled"; > > + }; > > + > > + vin14: video@e6efe000 { > > + compatible = "renesas,vin-r8a779a0"; > > + reg = <0 0xe6efe000 0 0x1000>; > > + interrupts = ; > > + clocks = <&cpg CPG_MOD 812>; > > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>; > > + resets = <&cpg 812>; > > + status = "disabled"; > > + }; > > + > > + vin15: video@e6eff000 { > > + compatible = "renesas,vin-r8a779a0"; > > + reg = <0 0xe6eff000 0 0x1000>; > > + interrupts = ; > > + clocks = <&cpg CPG_MOD 813>; > > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>; > > + resets = <&cpg 813>; > > + status = "disabled"; > > + }; > > + > > + vin16: video@e6ed0000 { > > + compatible = "renesas,vin-r8a779a0"; > > + reg = <0 0xe6ed0000 0 0x1000>; > > + interrupts = ; > > + clocks = <&cpg CPG_MOD 814>; > > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>; > > + resets = <&cpg 814>; > > + status = "disabled"; > > + }; > > + > > + vin17: video@e6ed1000 { > > + compatible = "renesas,vin-r8a779a0"; > > + reg = <0 0xe6ed1000 0 0x1000>; > > + interrupts = ; > > + clocks = <&cpg CPG_MOD 815>; > > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>; > > + resets = <&cpg 815>; > > + status = "disabled"; > > + }; > > + > > + vin18: video@e6ed2000 { > > + compatible = "renesas,vin-r8a779a0"; > > + reg = <0 0xe6ed2000 0 0x1000>; > > + interrupts = ; > > + clocks = <&cpg CPG_MOD 816>; > > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>; > > + resets = <&cpg 816>; > > + status = "disabled"; > > + }; > > + > > + vin19: video@e6ed3000 { > > + compatible = "renesas,vin-r8a779a0"; > > + reg = <0 0xe6ed3000 0 0x1000>; > > + interrupts = ; > > + clocks = <&cpg CPG_MOD 817>; > > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>; > > + resets = <&cpg 817>; > > + status = "disabled"; > > + }; > > + > > + vin20: video@e6ed4000 { > > + compatible = "renesas,vin-r8a779a0"; > > + reg = <0 0xe6ed4000 0 0x1000>; > > + interrupts = ; > > + clocks = <&cpg CPG_MOD 818>; > > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>; > > + resets = <&cpg 818>; > > + status = "disabled"; > > + }; > > + > > + vin21: video@e6ed5000 { > > + compatible = "renesas,vin-r8a779a0"; > > + reg = <0 0xe6ed5000 0 0x1000>; > > + interrupts = ; > > + clocks = <&cpg CPG_MOD 819>; > > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>; > > + resets = <&cpg 819>; > > + status = "disabled"; > > + }; > > + > > + vin22: video@e6ed6000 { > > + compatible = "renesas,vin-r8a779a0"; > > + reg = <0 0xe6ed6000 0 0x1000>; > > + interrupts = ; > > + clocks = <&cpg CPG_MOD 820>; > > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>; > > + resets = <&cpg 820>; > > + status = "disabled"; > > + }; > > + > > + vin23: video@e6ed7000 { > > + compatible = "renesas,vin-r8a779a0"; > > + reg = <0 0xe6ed7000 0 0x1000>; > > + interrupts = ; > > + clocks = <&cpg CPG_MOD 821>; > > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>; > > + resets = <&cpg 821>; > > + status = "disabled"; > > + }; > > + > > + vin24: video@e6ed8000 { > > + compatible = "renesas,vin-r8a779a0"; > > + reg = <0 0xe6ed8000 0 0x1000>; > > + interrupts = ; > > + clocks = <&cpg CPG_MOD 822>; > > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>; > > + resets = <&cpg 822>; > > + status = "disabled"; > > + }; > > + > > + vin25: video@e6ed9000 { > > + compatible = "renesas,vin-r8a779a0"; > > + reg = <0 0xe6ed9000 0 0x1000>; > > + interrupts = ; > > + clocks = <&cpg CPG_MOD 823>; > > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>; > > + resets = <&cpg 823>; > > + status = "disabled"; > > + }; > > + > > + vin26: video@e6eda000 { > > + compatible = "renesas,vin-r8a779a0"; > > + reg = <0 0xe6eda000 0 0x1000>; > > + interrupts = ; > > + clocks = <&cpg CPG_MOD 824>; > > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>; > > + resets = <&cpg 824>; > > + status = "disabled"; > > + }; > > + > > + vin27: video@e6edb000 { > > + compatible = "renesas,vin-r8a779a0"; > > + reg = <0 0xe6edb000 0 0x1000>; > > + interrupts = ; > > + clocks = <&cpg CPG_MOD 825>; > > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>; > > + resets = <&cpg 825>; > > + status = "disabled"; > > + }; > > + > > + vin28: video@e6edc000 { > > + compatible = "renesas,vin-r8a779a0"; > > + reg = <0 0xe6edc000 0 0x1000>; > > + interrupts = ; > > + clocks = <&cpg CPG_MOD 826>; > > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>; > > + resets = <&cpg 826>; > > + status = "disabled"; > > + }; > > + > > + vin29: video@e6edd000 { > > + compatible = "renesas,vin-r8a779a0"; > > + reg = <0 0xe6edd000 0 0x1000>; > > + interrupts = ; > > + clocks = <&cpg CPG_MOD 827>; > > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>; > > + resets = <&cpg 827>; > > + status = "disabled"; > > + }; > > + > > + vin30: video@e6ede000 { > > + compatible = "renesas,vin-r8a779a0"; > > + reg = <0 0xe6ede000 0 0x1000>; > > + interrupts = ; > > + clocks = <&cpg CPG_MOD 828>; > > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>; > > + resets = <&cpg 828>; > > + status = "disabled"; > > + }; > > + > > + vin31: video@e6edf000 { > > + compatible = "renesas,vin-r8a779a0"; > > + reg = <0 0xe6edf000 0 0x1000>; > > + interrupts = ; > > + clocks = <&cpg CPG_MOD 829>; > > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>; > > + resets = <&cpg 829>; > > + status = "disabled"; > > + }; > > + > > csi40: csi2@feaa0000 { > > compatible = "renesas,r8a779a0-csi2"; > > reg = <0 0xfeaa0000 0 0x10000>; > > -- > > 2.28.0 > > > > -- > Regards, > Niklas Söderlund