From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8BA4C433DF for ; Wed, 14 Oct 2020 02:06:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 88395221FF for ; Wed, 14 Oct 2020 02:06:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602641203; bh=jZwx6dNORFolKsYZwx40kGR6v5LVfiUDzJP9RuoekwA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=QIYmXTVHouHN6yYwa1hqIC1jhnITcbnUFXOQjuuVxHQxltcTCNUXHUFlAR8xBE9+D oHFT4hYlh3YTwUNIcwm8XpoPaZ4/D/eSjpVq8sbGiCwsast0ljGacohp0JZRDCTndU v8K3jksfxPrK3fwbAFMh681M9wLmDKvo7LdW2MBE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728636AbgJNCGm (ORCPT ); Tue, 13 Oct 2020 22:06:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:56200 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725874AbgJNCGl (ORCPT ); Tue, 13 Oct 2020 22:06:41 -0400 Received: from devnote2 (NE2965lan1.rev.em-net.ne.jp [210.141.244.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 972ED21775; Wed, 14 Oct 2020 02:06:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602641201; bh=jZwx6dNORFolKsYZwx40kGR6v5LVfiUDzJP9RuoekwA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=aMlchvmwHSP5HtTjuq11CxORl0dXu2Y/U8u6WQrI5BswRSeQMrBOHIxUpUQszkbd0 8u/rCx5914T3U5sJ3JihIDYKKguW5tpIcPOl/KbfHvP2p2Khg8tSakLPEAYMgiScxt hXs6CvAIxxxUpiCZWbMhmoo01XSpma+Hol67bhaY= Date: Wed, 14 Oct 2020 11:06:36 +0900 From: Masami Hiramatsu To: Tom Zanussi Cc: rostedt@goodmis.org, axelrasmussen@google.com, mhiramat@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 7/7] selftests/ftrace: Add test case for synthetic event syntax errors Message-Id: <20201014110636.139df7be275d40a23b523b84@kernel.org> In-Reply-To: References: X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tom, On Tue, 13 Oct 2020 09:17:58 -0500 Tom Zanussi wrote: > Add a selftest that verifies that the syntax error messages and caret > positions are correct for most of the possible synthetic event syntax > error cases. > > Signed-off-by: Tom Zanussi > --- > .../trigger-synthetic_event_syntax_errors.tc | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > create mode 100644 tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-synthetic_event_syntax_errors.tc > > diff --git a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-synthetic_event_syntax_errors.tc b/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-synthetic_event_syntax_errors.tc > new file mode 100644 > index 000000000000..ada594fe16cb > --- /dev/null > +++ b/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-synthetic_event_syntax_errors.tc > @@ -0,0 +1,19 @@ > +#!/bin/sh > +# SPDX-License-Identifier: GPL-2.0 > +# description: event trigger - test synthetic_events syntax parser errors > +# requires: synthetic_events error_log This also requires dynamic strings support. So, its "requires" line should be # requires: synthetic_events error_log "char name[]' >> synthetic_events":README > + > +check_error() { # command-with-error-pos-by-^ > + ftrace_errlog_check 'synthetic_events' "$1" 'synthetic_events' > +} > + BTW, some errors looks a bit odd. > +check_error 'myevent ^chr arg' # INVALID_TYPE > +check_error 'myevent ^char str[];; int v' # INVALID_TYPE I think there is a wrong "void" argument between ";", instead of invalid type. > +check_error 'myevent char ^str]; int v' # INVALID_NAME > +check_error 'myevent char ^str;[]' # INVALID_NAME This is also not an invalid name but '[]' is an invalid type. > +check_error 'myevent ^char str[; int v' # INVALID_TYPE > +check_error '^mye;vent char str[]' # BAD_NAME > +check_error 'myevent char str[]; ^int' # INVALID_FIELD Isn't it an incomplete command? > +check_error '^myevent' # INCOMPLETE_CMD > + > +exit 0 Thank you, > -- > 2.17.1 > -- Masami Hiramatsu