From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D81CFC433E7 for ; Wed, 14 Oct 2020 17:39:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8636E221EB for ; Wed, 14 Oct 2020 17:39:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731707AbgJNRjL (ORCPT ); Wed, 14 Oct 2020 13:39:11 -0400 Received: from foss.arm.com ([217.140.110.172]:54734 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727924AbgJNRjK (ORCPT ); Wed, 14 Oct 2020 13:39:10 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 32359D6E; Wed, 14 Oct 2020 10:39:10 -0700 (PDT) Received: from bogus (unknown [10.57.12.254]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D234B3F71F; Wed, 14 Oct 2020 10:39:08 -0700 (PDT) Date: Wed, 14 Oct 2020 18:39:06 +0100 From: Sudeep Holla To: Florian Fainelli Cc: Cristian Marussi , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sudeep Holla , Jonathan Cameron Subject: Re: [PATCH] firmware: arm_scmi: Fix duplicate workqueue name Message-ID: <20201014173906.aytbl4bjbwjwa6wr@bogus> References: <20201014021737.287340-1-f.fainelli@gmail.com> <20201014091806.GB20315@bogus> <20201014130524.cj42wknvzdpgsbsr@bogus> <20201014134819.GA24061@e120937-lin> <20201014160120.4x2l7hozf376gk3l@bogus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20171215 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 14, 2020 at 10:13:04AM -0700, Florian Fainelli wrote: > On 10/14/20 9:18 AM, Sudeep Holla wrote: > > On Wed, Oct 14, 2020 at 02:48:19PM +0100, Cristian Marussi wrote: > > > > [...] > > > >>> > >>> I have pushed a version with above change [1], please check if you are > >>> happy with that ? > >>> > >>> [1] https://git.kernel.org/sudeep.holla/linux/c/b2cd15549b > >> > >> I agree with the need to retain _notify name, but I'm not so sure about > >> the above patch...which is: > >> > > > > I agree, I thought about it and just cooked up this as a quick solution. > > I will move to that, even I wasn't happy with this TBH. > > The reason why I went with just dev_name() was such that the workqueue > name and the device nodes under /sys would strictly match, which helps > as an user, and also it avoided the temporary buffer and its size > limitations. Agreed. I just showed that as example and was hoping to use some nice kstr* APIs to achieve what I wanted but soon realised there exists none. So as replied earlier, I will take this change as it for now. Let us address this in future if it becomes an issue. Thanks for quick test, we now know whom to bother if we need more testing 😉 as out internal platforms are not that great to cover all the aspects we add in the spec and even in the kernel. -- Regards, Sudeep