From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09AEEC433E7 for ; Thu, 15 Oct 2020 04:31:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8EAC22225C for ; Thu, 15 Oct 2020 04:31:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="RhxJv6V2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727534AbgJOEbH (ORCPT ); Thu, 15 Oct 2020 00:31:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49350 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725208AbgJOEbH (ORCPT ); Thu, 15 Oct 2020 00:31:07 -0400 Received: from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com [IPv6:2607:f8b0:4864:20::1043]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28568C061755 for ; Wed, 14 Oct 2020 21:31:07 -0700 (PDT) Received: by mail-pj1-x1043.google.com with SMTP id hk7so1148284pjb.2 for ; Wed, 14 Oct 2020 21:31:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=1z00HM1oJWpdTbX+YMPLZimSogxpQwLPHkUejQUce64=; b=RhxJv6V2WOuh02i/6FfdUpPNGHak72ni/501XgVQTKAfCMPuG4Gc6DcST1NvZcx++M QRA1y4xTETTq6iEuOFgJX2d/SNf+89MPLavxyACaGI85QNfoPuhzJU3Sg/HIPJwu2IKZ DNh28elij0nsMs3gNecVl/rQHT4GQsbYVTw5Y9klFgZx76LjOk1jftCyxnvgjpA8dsWE ilD7xp0EKR+p3gWwm2hA1tCFnhhYACBBJ/qJPaQ24qfakQYjcd+9WOwqfsNQPqRAEoQA xgSAKbDdRjDbads6MMNuxpfyHkgqA2P4jTq6uFsaWwdK7g8AI+7gvLL9kRxMadA5fLAi 9UlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=1z00HM1oJWpdTbX+YMPLZimSogxpQwLPHkUejQUce64=; b=qO19lCjCGrBWAdFNic59fF7ISzomrTeXxIO9YYvK7Ilg4cgVFeOA+AUNZSxQFJ9TAl lAelaguhGnuxXt0toUL7N9Xch8x2s0cTuqcDiGgMu0dRYNRT8QMsNkiyBDwKE/LwxQwC x0Ze7UDFNTQSXU11Uqtyqx/RoW7pVRTAoIrExKrdJHdUECBt9gxeDEXRli3vcZ2eKyGA 9v+V2Jgyp4DiZzk0c2IJA5R5V7/qN98dPDbmrGsiQB1kWExt01y2/v1d/QAHVMxxO0Jm Q2kQCuXCZnUUUjJZQsL14cHPvkrxHd8xTTm5P7T3K9oLvRVid1yeWr/yQO7jMhLH//TG 59IQ== X-Gm-Message-State: AOAM5309CXEvZAPMBD/+iDOKwmy+jfL5810k6pueUkC24HJUeRI8bIo9 y8TZ7hML5eopD8KgeYVi+IthbQ== X-Google-Smtp-Source: ABdhPJw+iharOgIGCo8f+kM8aplb7DCE9ZqAKiUJiB8uvj0NHfZh9j8Pu1sfz1nYj5vTwDyJ9OTvYQ== X-Received: by 2002:a17:90b:4617:: with SMTP id ia23mr2584683pjb.120.1602736266692; Wed, 14 Oct 2020 21:31:06 -0700 (PDT) Received: from localhost ([122.181.54.133]) by smtp.gmail.com with ESMTPSA id e4sm1244336pgg.37.2020.10.14.21.31.05 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Oct 2020 21:31:05 -0700 (PDT) Date: Thu, 15 Oct 2020 10:01:03 +0530 From: Viresh Kumar To: Aisheng Dong Cc: Rafael Wysocki , Viresh Kumar , Nishanth Menon , Stephen Boyd , "linux-pm@vger.kernel.org" , Vincent Guittot , "linux-kernel@vger.kernel.org" , dl-linux-imx Subject: Re: [PATCH] opp: Don't always remove static OPPs in _of_add_opp_table_v1() Message-ID: <20201015043103.m6ghom52sqssh24z@vireshk-i7> References: <2c73ab54717ef358b118ea0cfb727b1427e7730a.1602648719.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716-391-311a52 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15-10-20, 02:35, Aisheng Dong wrote: > Hi Viresh > > Thanks for the quick fix. > > > From: Viresh Kumar > > Sent: Wednesday, October 14, 2020 12:26 PM > > > > The patch missed returning 0 early in case of success and hence the static OPPs > > got removed by mistake. Fix it. > > > > Fixes: 90d46d71cce2 ("opp: Handle multiple calls for same OPP table in > > _of_add_opp_table_v1()") > > Reported-by: Aisheng Dong > > Signed-off-by: Viresh Kumar > > Tested-by: Dong Aisheng Thanks. Rafael: Please apply this one directly for 5.10-rc. Thanks. -- viresh