mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Leo Yan <leo.yan@linaro.org>
To: Joe Mario <jmario@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
	Andi Kleen <ak@linux.intel.com>, David Ahern <dsahern@gmail.com>,
	Don Zickus <dzickus@redhat.com>, Al Grant <Al.Grant@arm.com>,
	James Clark <james.clark@arm.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 0/8] perf c2c: Refine the organization of metrics
Date: Thu, 15 Oct 2020 23:04:48 +0800	[thread overview]
Message-ID: <20201015150448.GB462@leoy-ThinkPad-X240s> (raw)
In-Reply-To: <79f2db37-a03f-c01f-0b3b-4e2d3ed429f4@redhat.com>

Hi Joe,

On Wed, Oct 14, 2020 at 02:38:19PM -0400, Joe Mario wrote:

[...]

> > This patch set is to refine metrics output organization.

[...]

> Hi Leo:
> I ran your patches through some perf c2c tests and it all looks good.  
> I agree the new format of the "Shared Data Cache Line Table" makes more sense now.  And it still holds together nicely when sorted on local HitMs (-d lcl).
> 
> Thank you for doing this.
> Joe
> 
> Tested-by: Joe Mario <jmario@redhat.com>

Thank you for quick response and testing.

I share the same thinking with Jiri that we should respect the existed
usages and habits of the tool, I was also a bit concern that my changes
might introduce inconvinence for others.  But it's great that receive
your agreement for the changes!

I have respinned the patch set v2 [1] with adding your test tag and
updated documentation; furthermore, I sent out another patch set for
enhancement perf c2c with sorting on LLC load hit, you are welcome to
reivew and comment on it [2].

Thanks,
Leo

[1] https://lore.kernel.org/patchwork/cover/1321499/
[2] https://lore.kernel.org/patchwork/cover/1321514/

      reply	other threads:[~2020-10-15 15:05 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-14  5:09 Leo Yan
2020-10-14  5:09 ` [PATCH v1 1/8] perf c2c: Display the total numbers continuously Leo Yan
2020-10-14  5:09 ` [PATCH v1 2/8] perf c2c: Display "Total Stores" as a standalone metrics Leo Yan
2020-10-14  5:09 ` [PATCH v1 3/8] perf c2c: Organize metrics based on memory hierarchy Leo Yan
2020-10-14  5:09 ` [PATCH v1 4/8] perf c2c: Change header from "LLC Load Hitm" to "Load Hitm" Leo Yan
2020-10-14  5:09 ` [PATCH v1 5/8] perf c2c: Use more explicit headers for HITM Leo Yan
2020-10-14  5:09 ` [PATCH v1 6/8] perf c2c: Change header for LLC local hit Leo Yan
2020-10-14  5:09 ` [PATCH v1 7/8] perf c2c: Correct LLC load hit metrics Leo Yan
2020-10-14  5:09 ` [PATCH v1 8/8] perf c2c: Add metrics "RMT Load Hit" Leo Yan
2020-10-14 14:03 ` [PATCH v1 0/8] perf c2c: Refine the organization of metrics Jiri Olsa
2020-10-14 18:38 ` Joe Mario
2020-10-15 15:04   ` Leo Yan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201015150448.GB462@leoy-ThinkPad-X240s \
    --to=leo.yan@linaro.org \
    --cc=Al.Grant@arm.com \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=dsahern@gmail.com \
    --cc=dzickus@redhat.com \
    --cc=james.clark@arm.com \
    --cc=jmario@redhat.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®