From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71399C43457 for ; Fri, 16 Oct 2020 02:34:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 22A0D20897 for ; Fri, 16 Oct 2020 02:34:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602815692; bh=wgurwTerQ1P/meEIJ41flc1QgAVRe5/Dfi5vOxe09rc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=2uwhyzN597xcTJdH4vGqRn8UKu167KhNg9wYJ0576tevpy4YbITKfOVEDC8lxuIBd JFGY6ZDjwnruX21gq3qvIuhI9bo6lSHbr8my5ob1jMVo1LIDJH+14YoJSQA04J8LbP 3nRFfCTMnOdvFXJpmnyjFfVK2vDj6FMjmCd0vzAU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404189AbgJPCev (ORCPT ); Thu, 15 Oct 2020 22:34:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:55476 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404178AbgJPCeu (ORCPT ); Thu, 15 Oct 2020 22:34:50 -0400 Received: from devnote2 (NE2965lan1.rev.em-net.ne.jp [210.141.244.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 300C720878; Fri, 16 Oct 2020 02:34:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602815690; bh=wgurwTerQ1P/meEIJ41flc1QgAVRe5/Dfi5vOxe09rc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=nkfJ6Q/Q3tcGvmzBTyfkTAEYV1zGi8EnSX6c1jl4ED6X9l/jjs9hOqp7LPZpgMkj+ 5I/IWmUkV24magig5hppYc+Tk/Dcc5dFJMi3SRROAoo3v79a7yLdHRU9OdfVN51+SP EE1TNfrt8zDEBestllDF3ocWXnbqwxRFh+HzIn2Q= Date: Fri, 16 Oct 2020 11:34:45 +0900 From: Masami Hiramatsu To: Linus Torvalds Cc: Steven Rostedt , LKML , Ingo Molnar , Andrew Morton , Masami Hiramatsu , Tom Zanussi Subject: Re: [GIT PULL] tracing: Updates for 5.10 Message-Id: <20201016113445.4bd2a37c9b5e7f3a065b6f52@kernel.org> In-Reply-To: References: <20201015135345.6b29e8c0@gandalf.local.home> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 15 Oct 2020 18:54:34 -0700 Linus Torvalds wrote: > On Thu, Oct 15, 2020 at 10:53 AM Steven Rostedt wrote: > > > > Updates for tracing and bootconfig: > > Hmm. I haven't verified that this came from you, but it seems likely.. > Once again my clang build shows something that I don't see in my > allmodconfig gcc build: > > WARNING: modpost: vmlinux.o(.text+0x1e5b06): Section mismatch in > reference from the function __trace_early_add_events() to the function > .init.text:__trace_early_add_new_event() > The function __trace_early_add_events() references > the function __init __trace_early_add_new_event(). > This is often because __trace_early_add_events lacks a __init > annotation or the annotation of __trace_early_add_new_event is wrong. > > Hmm? Oops, that's my fault. The commit 720dee53ad8d ("tracing/boot: Initialize per-instance event list in early boot") removes __init from __trace_early_add_events() but I forgot to do same on __trace_early_add_new_event(). Would this work? diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c index 851ab37058dd..e705f06c68c6 100644 --- a/kernel/trace/trace_events.c +++ b/kernel/trace/trace_events.c @@ -2498,7 +2498,7 @@ __trace_add_new_event(struct trace_event_call *call, struct trace_array *tr) * for enabling events at boot. We want to enable events before * the filesystem is initialized. */ -static __init int +static int __trace_early_add_new_event(struct trace_event_call *call, struct trace_array *tr) { -- Masami Hiramatsu