From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Dinghao Liu <dinghao.liu@zju.edu.cn>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
Sasha Levin <sashal@kernel.org>,
linux-media@vger.kernel.org
Subject: [PATCH AUTOSEL 4.19 12/56] media: platform: sti: hva: Fix runtime PM imbalance on error
Date: Sun, 18 Oct 2020 15:23:33 -0400 [thread overview]
Message-ID: <20201018192417.4055228-12-sashal@kernel.org> (raw)
In-Reply-To: <20201018192417.4055228-1-sashal@kernel.org>
From: Dinghao Liu <dinghao.liu@zju.edu.cn>
[ Upstream commit d912a1d9e9afe69c6066c1ceb6bfc09063074075 ]
pm_runtime_get_sync() increments the runtime PM usage counter even
when it returns an error code. Thus a pairing decrement is needed on
the error handling path to keep the counter balanced.
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/media/platform/sti/hva/hva-hw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/sti/hva/hva-hw.c b/drivers/media/platform/sti/hva/hva-hw.c
index 166ed30bbfce5..d826c011c0952 100644
--- a/drivers/media/platform/sti/hva/hva-hw.c
+++ b/drivers/media/platform/sti/hva/hva-hw.c
@@ -393,7 +393,7 @@ int hva_hw_probe(struct platform_device *pdev, struct hva_dev *hva)
ret = pm_runtime_get_sync(dev);
if (ret < 0) {
dev_err(dev, "%s failed to set PM\n", HVA_PREFIX);
- goto err_clk;
+ goto err_pm;
}
/* check IP hardware version */
--
2.25.1
next prev parent reply other threads:[~2020-10-18 19:40 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-18 19:23 [PATCH AUTOSEL 4.19 01/56] block: ratelimit handle_bad_sector() message Sasha Levin
2020-10-18 19:23 ` [PATCH AUTOSEL 4.19 02/56] crypto: ccp - fix error handling Sasha Levin
2020-10-18 19:23 ` [PATCH AUTOSEL 4.19 03/56] media: firewire: fix memory leak Sasha Levin
2020-10-18 19:23 ` [PATCH AUTOSEL 4.19 04/56] media: ati_remote: sanity check for both endpoints Sasha Levin
2020-10-18 19:23 ` [PATCH AUTOSEL 4.19 05/56] media: st-delta: Fix reference count leak in delta_run_work Sasha Levin
2020-10-18 19:23 ` [PATCH AUTOSEL 4.19 06/56] media: sti: Fix reference count leaks Sasha Levin
2020-10-18 19:23 ` [PATCH AUTOSEL 4.19 07/56] media: exynos4-is: Fix several reference count leaks due to pm_runtime_get_sync Sasha Levin
2020-10-18 19:23 ` [PATCH AUTOSEL 4.19 08/56] media: exynos4-is: Fix a reference count leak " Sasha Levin
2020-10-18 19:23 ` [PATCH AUTOSEL 4.19 09/56] media: exynos4-is: Fix a reference count leak Sasha Levin
2020-10-18 19:23 ` [PATCH AUTOSEL 4.19 10/56] media: vsp1: Fix runtime PM imbalance on error Sasha Levin
2020-10-18 19:23 ` [PATCH AUTOSEL 4.19 11/56] media: platform: s3c-camif: " Sasha Levin
2020-10-18 19:23 ` Sasha Levin [this message]
2020-10-18 19:23 ` [PATCH AUTOSEL 4.19 13/56] media: bdisp: " Sasha Levin
2020-10-18 19:23 ` [PATCH AUTOSEL 4.19 14/56] media: media/pci: prevent memory leak in bttv_probe Sasha Levin
2020-10-18 19:23 ` [PATCH AUTOSEL 4.19 15/56] media: uvcvideo: Ensure all probed info is returned to v4l2 Sasha Levin
2020-10-18 19:23 ` [PATCH AUTOSEL 4.19 16/56] seccomp: kill process instead of thread for unknown actions Sasha Levin
2020-10-18 19:23 ` [PATCH AUTOSEL 4.19 17/56] mmc: sdio: Check for CISTPL_VERS_1 buffer size Sasha Levin
2020-10-18 19:23 ` [PATCH AUTOSEL 4.19 18/56] media: saa7134: avoid a shift overflow Sasha Levin
2020-10-18 19:23 ` [PATCH AUTOSEL 4.19 19/56] fs: dlm: fix configfs memory leak Sasha Levin
2020-10-18 19:23 ` [PATCH AUTOSEL 4.19 20/56] media: venus: core: Fix runtime PM imbalance in venus_probe Sasha Levin
2020-10-18 19:23 ` [PATCH AUTOSEL 4.19 21/56] ipv6/icmp: l3mdev: Perform icmp error route lookup on source device routing table (v2) Sasha Levin
2020-10-18 19:23 ` [PATCH AUTOSEL 4.19 22/56] ntfs: add check for mft record size in superblock Sasha Levin
2020-10-18 19:23 ` [PATCH AUTOSEL 4.19 23/56] ip_gre: set dev->hard_header_len and dev->needed_headroom properly Sasha Levin
2020-10-18 19:23 ` [PATCH AUTOSEL 4.19 24/56] mac80211: handle lack of sband->bitrates in rates Sasha Levin
2020-10-18 19:23 ` [PATCH AUTOSEL 4.19 25/56] PM: hibernate: remove the bogus call to get_gendisk() in software_resume() Sasha Levin
2020-10-18 19:23 ` [PATCH AUTOSEL 4.19 26/56] scsi: mvumi: Fix error return in mvumi_io_attach() Sasha Levin
2020-10-18 19:23 ` [PATCH AUTOSEL 4.19 27/56] scsi: target: core: Add CONTROL field for trace events Sasha Levin
2020-10-18 19:23 ` [PATCH AUTOSEL 4.19 28/56] mic: vop: copy data to kernel space then write to io memory Sasha Levin
2020-10-18 19:23 ` [PATCH AUTOSEL 4.19 29/56] misc: vop: add round_up(x,4) for vring_size to avoid kernel panic Sasha Levin
2020-10-18 19:23 ` [PATCH AUTOSEL 4.19 30/56] usb: gadget: function: printer: fix use-after-free in __lock_acquire Sasha Levin
2020-10-18 19:23 ` [PATCH AUTOSEL 4.19 31/56] udf: Limit sparing table size Sasha Levin
2020-10-18 19:23 ` [PATCH AUTOSEL 4.19 32/56] udf: Avoid accessing uninitialized data on failed inode read Sasha Levin
2020-10-18 19:23 ` [PATCH AUTOSEL 4.19 33/56] USB: cdc-acm: handle broken union descriptors Sasha Levin
2020-10-18 19:23 ` [PATCH AUTOSEL 4.19 34/56] usb: dwc3: simple: add support for Hikey 970 Sasha Levin
2020-10-18 19:23 ` [PATCH AUTOSEL 4.19 35/56] can: flexcan: flexcan_chip_stop(): add error handling and propagate error value Sasha Levin
2020-10-18 19:23 ` [PATCH AUTOSEL 4.19 36/56] ath9k: hif_usb: fix race condition between usb_get_urb() and usb_kill_anchored_urbs() Sasha Levin
2020-10-18 19:23 ` [PATCH AUTOSEL 4.19 37/56] misc: rtsx: Fix memory leak in rtsx_pci_probe Sasha Levin
2020-10-18 19:23 ` [PATCH AUTOSEL 4.19 38/56] reiserfs: only call unlock_new_inode() if I_NEW Sasha Levin
2020-10-18 19:24 ` [PATCH AUTOSEL 4.19 39/56] xfs: make sure the rt allocator doesn't run off the end Sasha Levin
2020-10-18 19:24 ` [PATCH AUTOSEL 4.19 40/56] usb: ohci: Default to per-port over-current protection Sasha Levin
2020-10-18 19:24 ` [PATCH AUTOSEL 4.19 41/56] Bluetooth: Only mark socket zapped after unlocking Sasha Levin
2020-10-18 19:24 ` [PATCH AUTOSEL 4.19 42/56] scsi: ibmvfc: Fix error return in ibmvfc_probe() Sasha Levin
2020-10-18 19:24 ` [PATCH AUTOSEL 4.19 43/56] brcmsmac: fix memory leak in wlc_phy_attach_lcnphy Sasha Levin
2020-10-18 19:24 ` [PATCH AUTOSEL 4.19 44/56] rtl8xxxu: prevent potential memory leak Sasha Levin
2020-10-18 19:24 ` [PATCH AUTOSEL 4.19 45/56] Fix use after free in get_capset_info callback Sasha Levin
2020-10-18 19:24 ` [PATCH AUTOSEL 4.19 46/56] scsi: qedi: Protect active command list to avoid list corruption Sasha Levin
2020-10-18 19:24 ` [PATCH AUTOSEL 4.19 47/56] scsi: qedi: Fix list_del corruption while removing active I/O Sasha Levin
2020-10-18 19:24 ` [PATCH AUTOSEL 4.19 48/56] tty: ipwireless: fix error handling Sasha Levin
2020-10-18 19:24 ` [PATCH AUTOSEL 4.19 49/56] drm/amd/display: Fix a list corruption Sasha Levin
2020-10-18 19:24 ` [PATCH AUTOSEL 4.19 50/56] ipvs: Fix uninit-value in do_ip_vs_set_ctl() Sasha Levin
2020-10-18 19:24 ` [PATCH AUTOSEL 4.19 51/56] reiserfs: Fix memory leak in reiserfs_parse_options() Sasha Levin
2020-10-18 19:24 ` [PATCH AUTOSEL 4.19 52/56] mwifiex: don't call del_timer_sync() on uninitialized timer Sasha Levin
2020-10-18 19:24 ` [PATCH AUTOSEL 4.19 53/56] brcm80211: fix possible memleak in brcmf_proto_msgbuf_attach Sasha Levin
2020-10-18 19:24 ` [PATCH AUTOSEL 4.19 54/56] usb: core: Solve race condition in anchor cleanup functions Sasha Levin
2020-10-18 19:24 ` [PATCH AUTOSEL 4.19 55/56] scsi: ufs: ufs-qcom: Fix race conditions caused by ufs_qcom_testbus_config() Sasha Levin
2020-10-18 19:24 ` [PATCH AUTOSEL 4.19 56/56] ath10k: check idx validity in __ath10k_htt_rx_ring_fill_n() Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201018192417.4055228-12-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=dinghao.liu@zju.edu.cn \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®