From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E6D3C433DF for ; Mon, 19 Oct 2020 13:06:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CAF4F21D7B for ; Mon, 19 Oct 2020 13:06:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="noHyyoca" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727780AbgJSNGk (ORCPT ); Mon, 19 Oct 2020 09:06:40 -0400 Received: from mx2.suse.de ([195.135.220.15]:57470 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726336AbgJSNGj (ORCPT ); Mon, 19 Oct 2020 09:06:39 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1603112798; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=67anET1QIVAw8PGuoKV0jgAb85p9V9aPY7HbWEgrbgM=; b=noHyyocaqDpI/sEGx2l/xuLEhYEFzDh40rGduuiAe0QW/iZdvA0Ax/FPPprACgxLV2tQBH WyUjxBd9HdjFpFut9cVq4BbT5/gJBnKyR864qOgQQxha/PZ9Km1I9liOWBelJBaZEMloV7 FBkHkgUfcCH7O248e2HKkUxQeFdaJ/w= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 7A974AC97; Mon, 19 Oct 2020 13:06:38 +0000 (UTC) Date: Mon, 19 Oct 2020 15:06:37 +0200 From: Michal Hocko To: pintu@codeaurora.org Cc: willy@infradead.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, pintu.ping@gmail.com Subject: Re: [PATCH] mm/util.c: Add error logs for commitment overflow Message-ID: <20201019130637.GJ27114@dhcp22.suse.cz> References: <1601639861-32171-1-git-send-email-pintu@codeaurora.org> <20201002121726.GF4555@dhcp22.suse.cz> <20201005072011.GP4555@dhcp22.suse.cz> <0e9255fcac61ae6ce90bbdde6421b148@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0e9255fcac61ae6ce90bbdde6421b148@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 19-10-20 08:32:34, pintu@codeaurora.org wrote: [...] > b) This can be invoked from many places so we are adding the logging at > wrong layer? > If so, any other better places which can be explored? dup_mmap? > c) Adding logging at kernel layer is not the right approach to tackle this > problem ? > > d) Another thing we can do is, update the man page with more detailed > information about this commitment overflow ? This is a good thing in general > e) May be returning ENOMEM (Cannot allocate memory) from VM path is slightly > misleading for user space folks even though there are enough memory? > => Either we can introduce ENOVMEM (Cannot create virtual memory mapping) > => Or, update the documentation with approach to further debug this issue? No, it is close to impossible to add a new error code for interface that is used so heavily. -- Michal Hocko SUSE Labs