From: Pavel Machek <pavel@denx.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Dan Murphy <dmurphy@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
Johan Hovold <johan@kernel.org>,
linux-leds@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH v9 1/3] tty: rename tty_kopen() and add new function tty_kopen_shared()
Date: Tue, 20 Oct 2020 14:25:14 +0200 [thread overview]
Message-ID: <20201020122514.GB19856@duo.ucw.cz> (raw)
In-Reply-To: <20201018204022.910815-2-u.kleine-koenig@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 1039 bytes --]
Hi1
> Introduce a new function tty_kopen_shared() that yields a struct
> tty_struct. The semantic difference to tty_kopen() is that the tty is
> expected to be used already. So rename tty_kopen() to
> tty_kopen_exclusive() for clearness, adapt the single user and put the
> common code in a new static helper function.
>
> tty_kopen_shared is to be used to implement an LED trigger for tty
> devices in one of the next patches.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/accessibility/speakup/spk_ttyio.c | 2 +-
> drivers/tty/tty_io.c | 56 +++++++++++++++--------
> include/linux/tty.h | 5 +-
> 3 files changed, 42 insertions(+), 21 deletions(-)
> -struct tty_struct *tty_kopen(dev_t device)
> +static struct tty_struct *tty_kopen(dev_t device, int shared)
> {
bool? Otherwise I see nothing obviously wrong here.
But this is for Greg..
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2020-10-20 12:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-18 20:40 [PATCH v9 0/3] leds: trigger: implement a tty trigger Uwe Kleine-König
2020-10-18 20:40 ` [PATCH v9 1/3] tty: rename tty_kopen() and add new function tty_kopen_shared() Uwe Kleine-König
2020-10-20 12:25 ` Pavel Machek [this message]
2020-10-18 20:40 ` [PATCH v9 2/3] tty: new helper function tty_get_icount() Uwe Kleine-König
2020-10-20 12:25 ` Pavel Machek
2020-10-18 20:40 ` [PATCH v9 3/3] leds: trigger: implement a tty trigger Uwe Kleine-König
2020-10-20 12:36 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201020122514.GB19856@duo.ucw.cz \
--to=pavel@denx.de \
--cc=dmurphy@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=jacek.anaszewski@gmail.com \
--cc=johan@kernel.org \
--cc=jslaby@suse.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®