From: Steven Rostedt <rostedt@goodmis.org>
To: Zong Li <zong.li@sifive.com>
Cc: paulmck@kernel.org, josh@joshtriplett.org,
mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com,
joel@joelfernandes.org, vincent.whitchurch@axis.com,
tglx@linutronix.de, paul.walmsley@sifive.com,
palmerdabbelt@google.com, guoren@kernel.org,
atishp@atishpatra.org, mhiramat@kernel.org,
greentime.hu@sifive.com, colin.king@canonical.com,
rcu@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH] stop_machine: Mark functions as notrace
Date: Wed, 21 Oct 2020 10:15:22 -0400 [thread overview]
Message-ID: <20201021101522.3d1f3865@gandalf.local.home> (raw)
In-Reply-To: <20201021101216.4d840e15@gandalf.local.home>
On Wed, 21 Oct 2020 10:12:16 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> > Fixes: 4ecf0a43e729 ("processor: get rid of cpu_relax_yield")
> > Fixes: 366237e7b083 ("stop_machine: Provide RCU quiescent state in
> > multi_cpu_stop()")
>
> I really do not like to add "notrace" to core functions because a single
> architecture has issues with it. Why does RISCV have problems with these
> functions but no other architecture does?
>
> NACK from me until it is shown that these are issues for a broader set of
> architectures.
After looking at the two above fixes, I take back my NACK ;-)
One of them duplicates an already notraced function, so that looks fine.
The other makes a static function global, which could cause issues as well.
After further review:
Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
-- Steve
next prev parent reply other threads:[~2020-10-21 14:15 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-21 7:38 Zong Li
2020-10-21 14:12 ` Steven Rostedt
2020-10-21 14:15 ` Steven Rostedt [this message]
2020-10-21 15:44 ` Paul E. McKenney
2020-10-21 15:54 ` Steven Rostedt
2020-10-21 16:16 ` Paul E. McKenney
2020-10-22 0:58 ` Atish Patra
2020-10-23 19:29 ` Colin Ian King
2020-10-26 2:56 ` Zong Li
2020-10-26 11:17 ` [tip: smp/urgent] stop_machine, rcu: " tip-bot2 for Zong Li
2020-10-28 15:44 ` [PATCH] stop_machine: " Guo Ren
2020-10-29 0:23 ` Atish Patra
2020-10-29 2:34 ` Zong Li
2020-10-29 16:06 ` Guo Ren
2020-10-29 18:46 ` Atish Patra
2020-10-30 3:28 ` Guo Ren
2020-10-30 21:47 ` Atish Patra
2020-10-31 0:28 ` Steven Rostedt
2020-10-31 7:42 ` Guo Ren
2020-11-03 15:33 ` Atish Patra
2020-11-06 2:44 ` Guo Ren
2020-10-29 16:01 ` Guo Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201021101522.3d1f3865@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=atishp@atishpatra.org \
--cc=colin.king@canonical.com \
--cc=greentime.hu@sifive.com \
--cc=guoren@kernel.org \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=palmerdabbelt@google.com \
--cc=paul.walmsley@sifive.com \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=vincent.whitchurch@axis.com \
--cc=zong.li@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®