From: Pavel Machek <pavel@ucw.cz>
To: Pavel Pisa <pisa@cmp.felk.cvut.cz>
Cc: linux-can@vger.kernel.org, devicetree@vger.kernel.org,
Marc Kleine-Budde <mkl@pengutronix.de>,
Oliver Hartkopp <socketcan@hartkopp.net>,
Wolfgang Grandegger <wg@grandegger.com>,
David Miller <davem@davemloft.net>,
Rob Herring <robh+dt@kernel.org>,
mark.rutland@arm.com, Carsten Emde <c.emde@osadl.org>,
armbru@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Marin Jerabek <martin.jerabek01@gmail.com>,
Ondrej Ille <ondrej.ille@gmail.com>,
Jiri Novak <jnovak@fel.cvut.cz>,
Jaroslav Beran <jara.beran@gmail.com>,
Petr Porazil <porazil@pikron.com>,
Drew Fustini <pdp7pdp7@gmail.com>
Subject: Re: [PATCH v6 4/6] can: ctucanfd: CTU CAN FD open-source IP core - PCI bus support.
Date: Thu, 22 Oct 2020 13:39:52 +0200 [thread overview]
Message-ID: <20201022113952.GC30566@duo.ucw.cz> (raw)
In-Reply-To: <9783a6d0a3e79ca4106cf1794aa06c8436700137.1603354744.git.pisa@cmp.felk.cvut.cz>
[-- Attachment #1: Type: text/plain, Size: 989 bytes --]
Hi!
> @@ -12,4 +12,13 @@ config CAN_CTUCANFD
>
> if CAN_CTUCANFD
>
> +config CAN_CTUCANFD_PCI
> + tristate "CTU CAN-FD IP core PCI/PCIe driver"
> + depends on PCI
> + help
> + This driver adds PCI/PCIe support for CTU CAN-FD IP core.
> + The project providing FPGA design for Intel EP4CGX15 based DB4CGX15
> + PCIe board with PiKRON.com designed transceiver riser shield is available
> + at https://gitlab.fel.cvut.cz/canbus/pcie-ctu_can_fd .
> +
> endif
Ok, now the if in the first patch makes sense. It can stay.
And it is separate module, so EXPORT_SYMBOLs make sense. Ok.
> +#ifndef PCI_VENDOR_ID_TEDIA
> +#define PCI_VENDOR_ID_TEDIA 0x1760
> +#endif
> +#define PCI_DEVICE_ID_ALTERA_CTUCAN_TEST 0xCAFD
> +#define PCI_DEVICE_ID_TEDIA_CTUCAN_VER21 0xff00
These should go elsewhere.
> +static bool use_msi = 1;
> +static bool pci_use_second = 1;
true?
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2020-10-22 11:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-22 8:36 [PATCH v6 0/6] CTU CAN FD open-source IP core SocketCAN driver, PCI, platform integration and documentation Pavel Pisa
2020-10-22 8:36 ` [PATCH v6 1/6] dt-bindings: vendor-prefix: add prefix for the Czech Technical University in Prague Pavel Pisa
2020-10-22 8:36 ` [PATCH v6 2/6] dt-bindings: net: can: binding for CTU CAN FD open-source IP core Pavel Pisa
2020-10-22 8:58 ` Pavel Machek
2020-10-22 8:36 ` [PATCH v6 3/6] can: ctucanfd: add support for CTU CAN FD open-source IP core - bus independent part Pavel Pisa
2020-10-22 11:02 ` Pavel Machek
2020-10-22 20:21 ` Pavel Pisa
[not found] ` <CAA7Zjpam0uFCXwXS4_X5Sq3wJcNUSxOxPiTm860OXDNs-xHgyg@mail.gmail.com>
2020-10-26 16:11 ` Pavel Pisa
2020-10-26 13:04 ` Pavel Pisa
2020-10-22 8:36 ` [PATCH v6 4/6] can: ctucanfd: CTU CAN FD open-source IP core - PCI bus support Pavel Pisa
2020-10-22 11:39 ` Pavel Machek [this message]
2020-10-22 16:19 ` Pavel Pisa
2020-10-22 8:36 ` [PATCH v6 5/6] can: ctucanfd: CTU CAN FD open-source IP core - platform/SoC support Pavel Pisa
2020-10-22 11:43 ` Pavel Machek
2020-10-22 16:06 ` Pavel Pisa
2020-10-22 20:50 ` Pavel Machek
2020-10-22 8:36 ` [PATCH v6 6/6] docs: ctucanfd: CTU CAN FD open-source IP core documentation Pavel Pisa
2020-10-22 11:25 ` Pavel Machek
2020-10-22 15:24 ` Pavel Pisa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201022113952.GC30566@duo.ucw.cz \
--to=pavel@ucw.cz \
--cc=armbru@redhat.com \
--cc=c.emde@osadl.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=jara.beran@gmail.com \
--cc=jnovak@fel.cvut.cz \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=martin.jerabek01@gmail.com \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=ondrej.ille@gmail.com \
--cc=pdp7pdp7@gmail.com \
--cc=pisa@cmp.felk.cvut.cz \
--cc=porazil@pikron.com \
--cc=robh+dt@kernel.org \
--cc=socketcan@hartkopp.net \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®