From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9EA0C388F2 for ; Thu, 22 Oct 2020 11:58:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 561EC221FE for ; Thu, 22 Oct 2020 11:58:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Lfpzj/X0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2897741AbgJVL6J (ORCPT ); Thu, 22 Oct 2020 07:58:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2897730AbgJVL6D (ORCPT ); Thu, 22 Oct 2020 07:58:03 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55BFEC0613CE; Thu, 22 Oct 2020 04:58:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=I6klDVnQcrqiqkHEDRJqE0N4Ugd/ob+1NQ2ptWfMYdk=; b=Lfpzj/X0purmxvaViHT2xcRSq2 i8pKJrLPnsXE/XCPBnEE7X+4reJKp30RjIEvOLZ2K9O0/hiaQjSCQXjfN6WCyiYuGWIzpMY3FVzb8 SvqcAujgUefDduyLEpTdxR1IjA5i+sxu3abYYV4WH75S/oOo7NlOSVaSKg5MKVpFKONifJAhf+ppl bb4P/Dt40ITxx6lgApona00JzQGEdqFZpqM54cq0KiyMni8aCnTROQVd9bJOtCbjMH/+a9Fd7xFrh XZyvRXMcfmQWQbV3Wx2MQJp3vNvDHWDSwQUdYAPnvG40RbarjETHkPQTlXATVgUkcpvJ0ax5pK5ds biBmVJ2w==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kVZEA-0007kY-1h; Thu, 22 Oct 2020 11:57:54 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 2197030377D; Thu, 22 Oct 2020 13:57:53 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 05AD2203CC4B2; Thu, 22 Oct 2020 13:57:53 +0200 (CEST) Date: Thu, 22 Oct 2020 13:57:52 +0200 From: Peter Zijlstra To: "Rafael J. Wysocki" Cc: Viresh Kumar , Ingo Molnar , Vincent Guittot , Zhang Rui , Daniel Lezcano , Amit Daniel Kachhap , Javi Merino , Amit Kucheria , Linux Kernel Mailing List , Quentin Perret , Rafael Wysocki , Linux PM , Lukasz Luba Subject: Re: [PATCH 2/2] thermal: cpufreq_cooling: Reuse effective_cpu_util() Message-ID: <20201022115752.GF2611@hirez.programming.kicks-ass.net> References: <20200716115605.GR10769@hirez.programming.kicks-ass.net> <20201022083255.37xl3lffwk5qo6uk@vireshk-i7> <20201022090523.GV2628@hirez.programming.kicks-ass.net> <20201022110656.gaphjv2tzhj4f5y6@vireshk-i7> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 22, 2020 at 01:30:01PM +0200, Rafael J. Wysocki wrote: > Many people use intel_pstate in the active mode with HWP enabled too. We now have HWP-passive supported, afaict. So we should discourage that. That is; I'll care less and less about people not using schedutil as time goes on. > Arguably, that doesn't need to compute the effective utilization, so I > guess it is not relevant for the discussion here, but it is not > negligible in general. Why not? cpufreq-cooling should still be able to throttle the system by setting HWP.Highest_Performance no? In which case it still needs an energy estimate.