From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E05CAC4363A for ; Fri, 23 Oct 2020 05:11:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 761CD20797 for ; Fri, 23 Oct 2020 05:11:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="YcYR9zUc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2897273AbgJWFLQ (ORCPT ); Fri, 23 Oct 2020 01:11:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2896917AbgJWFLQ (ORCPT ); Fri, 23 Oct 2020 01:11:16 -0400 Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B853C0613D2 for ; Thu, 22 Oct 2020 22:11:16 -0700 (PDT) Received: by mail-pg1-x544.google.com with SMTP id b23so299689pgb.3 for ; Thu, 22 Oct 2020 22:11:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=bhDFTk2Ai9IvHYceetl+B1zPhbW6KMdcdI29Sg0Eo+M=; b=YcYR9zUcIUB4QIGYTdL3C7cdtzm1L9GbyIWrm9ZWiQ8goix/zhDkSZggOL5RqjkO/P wXfQzC5Dp20D6f1zcduUGvEar6jNSMUpS2LFjca49huhilc1uibA3ZlKnN3tNTMaE62T wzrkCCI34HrsTIFT3zj7VDqJt7Q+PO+P8zBixWe+RcojIdUkM5r9XNvLBpnesm9fO5Bz xtcBWcRNBXw6vEKO0VlENJYQvgIOy+qJS4vdgkO/6oDJbyCrCMTGs95Q3yiDuB0Zw8Hj 2LV2FUftIvhnhhmd8sg7GuY9hj9ypsS0qDzjiDlru6xPdcERrBgQhonVTIGUJu5fg0nQ CpGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=bhDFTk2Ai9IvHYceetl+B1zPhbW6KMdcdI29Sg0Eo+M=; b=tLdNsXlYaNGTrPgAGfs8YNfr/Si7VlSr4YJPQuHS43Na0Ww03RPqe8FXAMw+rjhiye 1MIdKcSjE9+vQtxBvvDPbxAvk2RUP5LuMvlUNweUqET9yjg1uwlwUJPiZ5NVY/u7D7C/ ILsvMlkjzj3aedMPitm2pVM3f2cyMDVflNPZskqkBYdW7KDLnbaWtXMyXZyWE7jqUkmc 04SZrvHfXKoM96DrjrcSC4KbiQkwL+Ct5h7ZhCqLyu7v5njQDA6p4vLIyEI8+ANUe+4X kJ9xtSNWxjcjn9afzO/L4RkgflTSfBQ12jjW8U2PDbcofcgKyAqvgtLCPm4OEnMWFW6Q uVvg== X-Gm-Message-State: AOAM533OS2d1d7Sy3ZG709F40d0bcZHdiMAo5CoatGX+mR1rcToVczes 0voL84BQsmzdG5lXAbYjBRYePA== X-Google-Smtp-Source: ABdhPJyN98CytOuNDU/P9oEgDgKuEou0RaGFmC2Be4QHtDolgE6CQO010qLoOYGeIeKGV40ISqebMw== X-Received: by 2002:a62:be04:0:b029:160:6c5:d7fe with SMTP id l4-20020a62be040000b029016006c5d7femr469851pff.21.1603429875495; Thu, 22 Oct 2020 22:11:15 -0700 (PDT) Received: from localhost ([122.181.54.133]) by smtp.gmail.com with ESMTPSA id y27sm499082pfr.122.2020.10.22.22.11.13 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Oct 2020 22:11:13 -0700 (PDT) Date: Fri, 23 Oct 2020 10:41:12 +0530 From: Viresh Kumar To: Vincent Guittot Cc: A L , Peter Zijlstra , "Rafael J. Wysocki" , Julia Lawall , Mel Gorman , Ingo Molnar , kernel-janitors@vger.kernel.org, Juri Lelli , Dietmar Eggemann , Steven Rostedt , Ben Segall , Daniel Bristot de Oliveira , linux-kernel , Valentin Schneider , Gilles Muller , Srinivas Pandruvada , Linux PM , Len Brown Subject: Re: default cpufreq gov, was: [PATCH] sched/fair: check for idle core Message-ID: <20201023051112.7p4qgr2opyoyeep4@vireshk-i7> References: <1603211879-1064-1-git-send-email-Julia.Lawall@inria.fr> <34115486.YmRjPRKJaA@kreacher> <20201022120213.GG2611@hirez.programming.kicks-ass.net> <1790766.jaFeG3T87Z@kreacher> <20201022122949.GW2628@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716-391-311a52 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22-10-20, 17:55, Vincent Guittot wrote: > On Thu, 22 Oct 2020 at 17:45, A L wrote: > > > > > > > > ---- From: Peter Zijlstra -- Sent: 2020-10-22 - 14:29 ---- > > > > > On Thu, Oct 22, 2020 at 02:19:29PM +0200, Rafael J. Wysocki wrote: > > >> > However I do want to retire ondemand, conservative and also very much > > >> > intel_pstate/active mode. > > >> > > >> I agree in general, but IMO it would not be prudent to do that without making > > >> schedutil provide the same level of performance in all of the relevant use > > >> cases. > > > > > > Agreed; I though to have understood we were there already. > > > > Hi, > > > > > > Currently schedutil does not populate all stats like ondemand does, which can be a problem for some monitoring software. > > > > On my AMD 3000G CPU with kernel-5.9.1: > > > > > > grep. /sys/devices/system/cpu/cpufreq/policy0/stats/* > > > > With ondemand: > > time_in_state:3900000 145179 > > time_in_state:1600000 9588482 > > total_trans:177565 > > trans_table: From : To > > trans_table: : 3900000 1600000 > > trans_table: 3900000: 0 88783 > > trans_table: 1600000: 88782 0 > > > > With schedutil only two file exists: > > reset: > > total_trans:216609 > > > > > > I'd really like to have these stats populated with schedutil, if that's possible. > > Your problem might have been fixed with > commit 96f60cddf7a1 ("cpufreq: stats: Enable stats for fast-switch as well") Thanks Vincent. Right, I have already fixed that for everyone. -- viresh