From: Peter Zijlstra <peterz@infradead.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Ingo Molnar <mingo@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Amit Daniel Kachhap <amit.kachhap@gmail.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Javi Merino <javi.merino@kernel.org>,
Zhang Rui <rui.zhang@intel.com>, Amit Kucheria <amitk@kernel.org>,
linux-kernel@vger.kernel.org, Quentin Perret <qperret@google.com>,
Lukasz Luba <lukasz.luba@arm.com>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH V2 2/2] thermal: cpufreq_cooling: Reuse sched_cpu_util()
Date: Fri, 23 Oct 2020 12:37:12 +0200 [thread overview]
Message-ID: <20201023103712.GL2594@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <11e7c7dcb07ae258fa02e187c9697252f3835466.1603448113.git.viresh.kumar@linaro.org>
On Fri, Oct 23, 2020 at 03:50:21PM +0530, Viresh Kumar wrote:
> Several parts of the kernel are already using the effective CPU
> utilization (as seen by the scheduler) to get the current load on the
> CPU, do the same here instead of depending on the idle time of the CPU,
> which isn't that accurate comparatively.
>
> Note that, this (and CPU frequency scaling in general) doesn't work that
> well with idle injection as that is done from rt threads and is counted
> as load while it tries to do quite the opposite. That should be solved
> separately though.
Actual numbers that show the goodness would be nice ;-) Because clearly
we're doing this make it better.
next prev parent reply other threads:[~2020-10-23 10:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-23 10:20 [PATCH V2 0/2] cpufreq_cooling: Get effective CPU utilization from scheduler Viresh Kumar
2020-10-23 10:20 ` [PATCH V2 1/2] sched/core: Rename and move schedutil_cpu_util() to core.c Viresh Kumar
2020-10-23 10:34 ` Peter Zijlstra
2020-10-23 10:54 ` Viresh Kumar
2020-10-23 11:08 ` Lukasz Luba
2020-10-23 12:34 ` Vincent Guittot
2020-10-28 5:49 ` Viresh Kumar
2020-10-23 10:43 ` Vincent Guittot
2020-10-23 10:55 ` Viresh Kumar
2020-10-23 10:20 ` [PATCH V2 2/2] thermal: cpufreq_cooling: Reuse sched_cpu_util() Viresh Kumar
2020-10-23 10:37 ` Peter Zijlstra [this message]
2020-11-12 9:41 ` Viresh Kumar
2020-10-23 16:22 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201023103712.GL2594@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=amit.kachhap@gmail.com \
--cc=amitk@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=javi.merino@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=mingo@redhat.com \
--cc=qperret@google.com \
--cc=rui.zhang@intel.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome