From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A475EC388F9 for ; Fri, 23 Oct 2020 11:05:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3F7092192A for ; Fri, 23 Oct 2020 11:05:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="XXB/jxGX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S462706AbgJWLFg (ORCPT ); Fri, 23 Oct 2020 07:05:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S462559AbgJWLFg (ORCPT ); Fri, 23 Oct 2020 07:05:36 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F496C0613CE for ; Fri, 23 Oct 2020 04:05:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Jnp658t1DDD6IIk2CsnZ4VQrdRxNgCykA+b+Xqnrt0c=; b=XXB/jxGXnn0cDQqUhob5WBh7gk aGisOUGNcBAO0YStP4+VoVuzzKRLOnHKNmtO7lTcto+p1IyIOMRrSZJKeNzfUPMlv4rODQpxsGzQ4 QFaKTqe/dkibNDCO8pzihdHNI0ZiNao7Ozny4Woggre19RHl6seKoKtfMjAcAGYkrmFmBl/NckjdA 4ONTCM3ZjjmbUn17MmbrH/4xNGD04cuQOMd8YqSK0fRs6iifkuaNklK8+V75beXEOHp4gbnhNiydW Gb4t1Ah7rTbN+w92RKm5aOUBtLu8+rptWoJQjUbfMAT6OuTIOJbL7ygpFDc+clCWRbxgjSZ7wRKa+ PdyerfiA==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kVusw-0005Tp-2U; Fri, 23 Oct 2020 11:05:26 +0000 Date: Fri, 23 Oct 2020 12:05:26 +0100 From: Christoph Hellwig To: NeilBrown Cc: Herbert Xu , Lai Jiangshan , Daniel Jordan , Thomas Gleixner , Sebastian Andrzej Siewior , LKML , Greg Kroah-Hartman Subject: Re: [PATCH] workqueue: export apply_workqueue_attrs() Message-ID: <20201023110526.GB20293@infradead.org> References: <87blgzf5xy.fsf@notabene.neil.brown.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87blgzf5xy.fsf@notabene.neil.brown.name> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 19, 2020 at 10:52:09AM +1100, NeilBrown wrote: > > Lustre is a widely used cluster filesystem which is currently > out-of-tree, but work is underway to make it ready for upstream > submission. > > Lustre needs apply_workqueue_attrs(), and for this reason that function > was exported in Commit 6106c0f82481 ("staging: lustre: lnet: convert > selftest to use workqueues"). None of this matters. We don't export unused symbols, period.