From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15D12C388F7 for ; Sun, 25 Oct 2020 18:37:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BC9D821D41 for ; Sun, 25 Oct 2020 18:37:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603651048; bh=AKPWbbhGU2lDq8bH1SvgMMUeWmC+dVgo7ZU0pT2CqBo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=vDm7aINIm9KPfUdIEBsMRPDaqvtmF+80zKOplUVyV4137EiRub5OVdXuMaIRQQ38X JyarXvJh0gwv9hoogfn0CNJGCinLuJmHMJaUkM76V0+b6PCItOYbA4UwIE+OoXhqo3 CkTQruX2Wa+ICOUXXWvdNrnZfrUSTRdGQu5DCpAw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1417164AbgJYSh1 (ORCPT ); Sun, 25 Oct 2020 14:37:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:49324 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1415361AbgJYSh0 (ORCPT ); Sun, 25 Oct 2020 14:37:26 -0400 Received: from X1 (nat-ab2241.sltdut.senawave.net [162.218.216.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1DC612072C; Sun, 25 Oct 2020 18:37:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603651046; bh=AKPWbbhGU2lDq8bH1SvgMMUeWmC+dVgo7ZU0pT2CqBo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=NrxUh7Ba2gTECKM/q2Nb8g7MqpeqjWVu+CAWoTjJUX/Xn1y/Q5hnn6KlhM+GpLPkg 2tNRiG7gHYOqtaJXG05Ww3O7BpZlEBqcme73OYOcJpfFNaDI0CpD94hEw4kvO5XbRg hNzx1hkDDMKIB1YweVadIc2+HdMbcNwoITFZpxe8= Date: Sun, 25 Oct 2020 11:37:25 -0700 From: Andrew Morton To: Johannes Weiner Cc: Michal Hocko , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH] mm: memcontrol: add file_thp, shmem_thp to memory.stat Message-Id: <20201025113725.b60f2b08d7331a31edf009a1@linux-foundation.org> In-Reply-To: <20201022151844.489337-1-hannes@cmpxchg.org> References: <20201022151844.489337-1-hannes@cmpxchg.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 22 Oct 2020 11:18:44 -0400 Johannes Weiner wrote: > As huge page usage in the page cache and for shmem files proliferates > in our production environment, the performance monitoring team has > asked for per-cgroup stats on those pages. > > We already track and export anon_thp per cgroup. We already track file > THP and shmem THP per node, so making them per-cgroup is only a matter > of switching from node to lruvec counters. All callsites are in places > where the pages are charged and locked, so page->memcg is stable. > > ... > > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -1507,6 +1507,8 @@ static struct memory_stat memory_stats[] = { > * constant(e.g. powerpc). > */ > { "anon_thp", 0, NR_ANON_THPS }, > + { "file_thp", 0, NR_FILE_THPS }, > + { "shmem_thp", 0, NR_SHMEM_THPS }, Documentation/admin-guide/cgroup-v2.rst is owed an update?