From: Pavel Machek <pavel@ucw.cz>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Ian Kent <raven@themaw.net>,
Ondrej Mosnacek <omosnace@redhat.com>,
Christoph Hellwig <hch@lst.de>,
kernel list <linux-kernel@vger.kernel.org>,
autofs@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
the arch/x86 maintainers <x86@kernel.org>,
Peter Anvin <hpa@zytor.com>
Subject: Re: autofs: use __kernel_write() for the autofs pipe writing causes regression in -next was Re: 5.9.0-next-20201015: autofs oops in update-binfmts
Date: Mon, 26 Oct 2020 09:38:37 +0100 [thread overview]
Message-ID: <20201026083836.GA24911@duo.ucw.cz> (raw)
In-Reply-To: <CAHk-=wikZkCGVkeuDUb6jvz7xyeO4RsH3zQU4bCCnP=MBrd95g@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 967 bytes --]
On Sat 2020-10-17 17:13:20, Linus Torvalds wrote:
> On Sat, Oct 17, 2020 at 12:48 PM Pavel Machek <pavel@ucw.cz> wrote:
> >
> > But: you are the last one to sign it off, so I assume committed it to
> > git, and you are the one to talk to about fixing it.
>
> The thing is, the commit you point to - and the one I signed off on - is fine.
>
> The buggy one is in linux-next, which breaks that whole "NULL means no
> position" thing.
>
> IOW, the real bug is in commit 4d03e3cc5982 ("fs: don't allow kernel
> reads and writes without iter ops"), which does that bogus
>
> kiocb.ki_pos = *pos;
>
> and no, I never signed off on that.
>
> Get it? Stop confusing people. This bug does not exist in mainline,
> and never will. Because I'm not pulling that buggy commit.
And I guess that's a good thing. It is now fixed in -next, too. Sorry
for the noise.
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2020-10-26 8:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-16 12:35 Pavel Machek
2020-10-17 2:11 ` Ian Kent
2020-10-17 10:02 ` autofs: use __kernel_write() for the autofs pipe writing causes regression in -next was " Pavel Machek
2020-10-17 18:05 ` Linus Torvalds
2020-10-17 19:47 ` Pavel Machek
2020-10-18 0:13 ` Linus Torvalds
2020-10-26 8:38 ` Pavel Machek [this message]
2020-10-18 7:22 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201026083836.GA24911@duo.ucw.cz \
--to=pavel@ucw.cz \
--cc=autofs@vger.kernel.org \
--cc=bp@alien8.de \
--cc=hch@lst.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=omosnace@redhat.com \
--cc=raven@themaw.net \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®