From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2492FC4363A for ; Mon, 26 Oct 2020 18:02:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CD7F12222C for ; Mon, 26 Oct 2020 18:02:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="akulYrwl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1788981AbgJZSCh (ORCPT ); Mon, 26 Oct 2020 14:02:37 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:46504 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731426AbgJZSCg (ORCPT ); Mon, 26 Oct 2020 14:02:36 -0400 Received: by mail-wr1-f66.google.com with SMTP id n6so13701503wrm.13 for ; Mon, 26 Oct 2020 11:02:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=dr/M5m284ccLeNOnUZwOiheVtoOaVvfBzrCmSiaeimE=; b=akulYrwlVSGJpPDC77vrNk+/ekLvFK7m9ZYXW18qFiVTxqz71UQD4kL34+wANlmTVv AEB34pClXCQubR8meZl1EWal3gpTwjpHWc2Py4ypB2QtxS+yy9sealpLbbu2FF8Jnl0+ 2+3nbJrORnVzZWi5pglb8E85aXluq/GZkhZ072/GAu0J4wnj3c90JbnN6WVg11WZ/jFr iWC9+ljZvMqkDtPVJlQdcCkmYLsNoDjjvTXdaMAlkBnGq+H/acQ+lYXejcXMJdnd2ko6 VjxQqpHN9OXq77dI8p8ags+eJ2ixfImHotPQoNSY4/EKPBEFPwr2OyZCupD8u8zgmVOm JOTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=dr/M5m284ccLeNOnUZwOiheVtoOaVvfBzrCmSiaeimE=; b=Q/vlXToVDwNJdyyBAM5Mau1udhpOzaKj5ZIg2DawoaGpM9Qn3Cz7gGC1cdf9sqsObI v+pXwhN3bOFyGat+ruo7N5d6EIdxY6Wrui3bHMW7SAVD/APiVf+fnfPTSTyUtBQ1sjcN +8ynFPM88vkcK2FZnzFROqMTJDkg0EEv/asjjkG/FDxdwdZxIRUvrqRL7sectbIj+G0W ZXkmgjuH9EeWvUrO2R0n/XFtKyZIvFou5arYYpF7A8DUfzx2IxgnpwjNWv0qpjcwcSoj voTm7PSbXZetxTiT8CFO343W1xscUzXPG7v1mf75qJWaX8Orkqey1riKGJk4qz/+oDBW ZCDw== X-Gm-Message-State: AOAM531AYa1L5/keiyewP91CS4+EFIIuiggF8eP7hHlMu8CncenTLamp O31Rp+Gxir+JkgO42KAfTZU= X-Google-Smtp-Source: ABdhPJy3v17H0nndO/wow3Iyw/sF1O6Mqems54hgdg6CPu8vTLvCzEuv3AXub44dapk3cnvbMC+Kiw== X-Received: by 2002:adf:e849:: with SMTP id d9mr20693375wrn.25.1603735355389; Mon, 26 Oct 2020 11:02:35 -0700 (PDT) Received: from localhost.localdomain (host-92-5-241-147.as43234.net. [92.5.241.147]) by smtp.gmail.com with ESMTPSA id r1sm25575100wro.18.2020.10.26.11.02.34 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Oct 2020 11:02:34 -0700 (PDT) From: Sudip Mukherjee To: John Stultz , Arnd Bergmann , Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, linux-safety@lists.elisa.tech, Sudip Mukherjee Subject: [PATCH] misc: hisi_hikey_usb: use PTR_ERR_OR_ZERO Date: Mon, 26 Oct 2020 18:00:26 +0000 Message-Id: <20201026180026.3350-1-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 2.11.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Coccinelle suggested using PTR_ERR_OR_ZERO() and looking at the code, we can use PTR_ERR_OR_ZERO() instead of checking IS_ERR() and then doing 'return 0'. Signed-off-by: Sudip Mukherjee --- drivers/misc/hisi_hikey_usb.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/misc/hisi_hikey_usb.c b/drivers/misc/hisi_hikey_usb.c index cc93569e601c..989d7d129469 100644 --- a/drivers/misc/hisi_hikey_usb.c +++ b/drivers/misc/hisi_hikey_usb.c @@ -168,10 +168,7 @@ static int hisi_hikey_usb_parse_kirin970(struct platform_device *pdev, hisi_hikey_usb->reset = devm_gpiod_get(&pdev->dev, "hub_reset_en_gpio", GPIOD_OUT_HIGH); - if (IS_ERR(hisi_hikey_usb->reset)) - return PTR_ERR(hisi_hikey_usb->reset); - - return 0; + return PTR_ERR_OR_ZERO(hisi_hikey_usb->reset); } static int hisi_hikey_usb_probe(struct platform_device *pdev) -- 2.11.0