From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 187F0C4363A for ; Mon, 26 Oct 2020 23:10:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BC51320780 for ; Mon, 26 Oct 2020 23:10:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603753858; bh=+rA3mXse0duYebj29NlP/iv4vLfme+C3PEBv33IDzrs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=nDitWc2EFsnMORz6Psfb3qqe58HCx3wFxSyBjPNX4pMKzKmqT6tglGX5xPS7HQNi2 43EaGbH3PZJy1uWLjWCRwyTtE7gKf5OZJbYmGLJ2bCYA3lkWcDKlaMBY8dj1P5fyVn StW0DnyKqrTK5c/FLqMEoFJQfTvhfGsmLxns2RVc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2395485AbgJZXK5 (ORCPT ); Mon, 26 Oct 2020 19:10:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:53028 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2395475AbgJZXK4 (ORCPT ); Mon, 26 Oct 2020 19:10:56 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6A32F20759; Mon, 26 Oct 2020 23:10:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603753856; bh=+rA3mXse0duYebj29NlP/iv4vLfme+C3PEBv33IDzrs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qHjp+5jrlZUjjS4s9kch5YsSP5uJuL32CjMBRUGnmzQsCPbIQTMYiby7XugKM1gVy Ef6vxvWkE8+t6r+VzMiqZ0YCq6Yoyhp3g4IouKpfw+h+BpJSFV8B8oodDAOh6K6xrs 3kSvxOS/fL+4dkwOH1wyjxOMiX5KPtqSOp+x770Q= Date: Mon, 26 Oct 2020 23:10:51 +0000 From: Mark Brown To: Tomasz Figa Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Cezary Rojewski , Pierre-Louis Bossart , Liam Girdwood , Jie Yang , Jaroslav Kysela , Takashi Iwai , cujomalainey@chromium.org, =?utf-8?Q?=C5=81ukasz?= Majczak Subject: Re: [PATCH] ASoC: Intel: kbl_rt5663_max98927: Fix kabylake_ssp_fixup function Message-ID: <20201026231051.GK7402@sirena.org.uk> References: <20201014141624.4143453-1-tfiga@chromium.org> <20201014190226.GE4580@sirena.org.uk> <20201026222747.GD2802004@chromium.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="T4Djgzn3z2HSNnx0" Content-Disposition: inline In-Reply-To: <20201026222747.GD2802004@chromium.org> X-Cookie: Safety Third. User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --T4Djgzn3z2HSNnx0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Oct 26, 2020 at 10:27:47PM +0000, Tomasz Figa wrote: > On Wed, Oct 14, 2020 at 08:02:26PM +0100, Mark Brown wrote: > > Please think hard before including complete backtraces in upstream > > reports, they are very large and contain almost no useful information > > relative to their size so often obscure the relevant content in your > > message. If part of the backtrace is usefully illustrative (it often is > > for search engines if nothing else) then it's usually better to pull out > > the relevant sections. > Okay, I'll trim things down next time. Somehow I was convinced it's a > common practice. It is unfortunately far more common than it should be but that doesn't mean that it's a good idea! --T4Djgzn3z2HSNnx0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl+XV3oACgkQJNaLcl1U h9DHEQf+P9XM66VGrpm7CJvgSRIOiFF94Fk/gQFsulGNkv+W9YcF+z4wsrEsR3kh 5bZuxRsp06aabr2ESWJ5pwQzMyH5q8E4Ou7UhOBxJHzBqr6imfzshTm/1X+4Orq2 tlkrkSxHdJt7Gm9/joTRrzs5S7agkKfRZKZdSpIN2ve5ztRqKL5tc310LMAwyOJF k6pezKd5Hb9ds7zWQ/yHMCTi/AUzPB9aPwI0nq5tgWbndsZ0hgSCI1Ze1gi05v/d y7jKlPQmYP5hvWRDNqsXx63M1jJKsh40+it8XQnxuaFG8k9kd9s8lGifmAGBEraE RBYD2VOBrziPtYW2uH3IT+G6xbSy3A== =oJS/ -----END PGP SIGNATURE----- --T4Djgzn3z2HSNnx0--