From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67A98C388F9 for ; Tue, 27 Oct 2020 12:42:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 214A721655 for ; Tue, 27 Oct 2020 12:42:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2900197AbgJ0Ml6 (ORCPT ); Tue, 27 Oct 2020 08:41:58 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:47198 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2900103AbgJ0Mlo (ORCPT ); Tue, 27 Oct 2020 08:41:44 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kXOI6-003nNe-Mu; Tue, 27 Oct 2020 13:41:30 +0100 Date: Tue, 27 Oct 2020 13:41:30 +0100 From: Andrew Lunn To: Mauro Carvalho Chehab Cc: Linux Doc Mailing List , Jonathan Corbet , Heiner Kallweit , Russell King , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Jakub Kicinski Subject: Re: [PATCH v3 14/32] net: phy: remove kernel-doc duplication Message-ID: <20201027124130.GB904240@lunn.ch> References: <75e9a357f9a716833d2094b04898754876365e68.1603791716.git.mchehab+huawei@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <75e9a357f9a716833d2094b04898754876365e68.1603791716.git.mchehab+huawei@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 27, 2020 at 10:51:18AM +0100, Mauro Carvalho Chehab wrote: > Sphinx 3 now checks for duplicated function declarations: > > .../Documentation/networking/kapi:143: ../include/linux/phy.h:163: WARNING: Duplicate C declaration, also defined in 'networking/kapi'. > Declaration is 'unsigned int phy_supported_speeds (struct phy_device *phy, unsigned int *speeds, unsigned int size)'. > .../Documentation/networking/kapi:143: ../include/linux/phy.h:1034: WARNING: Duplicate C declaration, also defined in 'networking/kapi'. > Declaration is 'int phy_read_mmd (struct phy_device *phydev, int devad, u32 regnum)'. > .../Documentation/networking/kapi:143: ../include/linux/phy.h:1076: WARNING: Duplicate C declaration, also defined in 'networking/kapi'. > Declaration is 'int __phy_read_mmd (struct phy_device *phydev, int devad, u32 regnum)'. > .../Documentation/networking/kapi:143: ../include/linux/phy.h:1088: WARNING: Duplicate C declaration, also defined in 'networking/kapi'. > Declaration is 'int phy_write_mmd (struct phy_device *phydev, int devad, u32 regnum, u16 val)'. > .../Documentation/networking/kapi:143: ../include/linux/phy.h:1100: WARNING: Duplicate C declaration, also defined in 'networking/kapi'. > Declaration is 'int __phy_write_mmd (struct phy_device *phydev, int devad, u32 regnum, u16 val)'. > > It turns that both the C and the H files have the same > kernel-doc markup for the same functions. Let's drop the > at the header file, keeping the one closer to the code. > > Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Andrew Lunn Andrew