From: Peter Zijlstra <peterz@infradead.org>
To: Andy Lutomirski <luto@kernel.org>
Cc: Kyle Huey <me@kylehuey.com>,
open list <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
"maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<x86@kernel.org>, Linus Torvalds <torvalds@linux-foundation.org>,
Robert O'Callahan <rocallahan@gmail.com>,
Alexandre Chartre <alexandre.chartre@oracle.com>,
"Paul E. McKenney" <paulmck@kernel.org>,
Frederic Weisbecker <frederic@kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Sean Christopherson <sean.j.christopherson@intel.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Petr Mladek <pmladek@suse.com>,
Joel Fernandes <joel@joelfernandes.org>,
Steven Rostedt <rostedt@goodmis.org>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Juergen Gross <jgross@suse.com>, Brian Gerst <brgerst@gmail.com>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Daniel Thompson <daniel.thompson@linaro.org>
Subject: Re: [REGRESSION] x86/debug: After PTRACE_SINGLESTEP DR_STEP is no longer reported in dr6
Date: Tue, 27 Oct 2020 18:56:17 +0100 [thread overview]
Message-ID: <20201027175617.GF2651@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20201027090814.GJ2628@hirez.programming.kicks-ass.net>
On Tue, Oct 27, 2020 at 10:08:14AM +0100, Peter Zijlstra wrote:
> On Mon, Oct 26, 2020 at 04:30:32PM -0700, Andy Lutomirski wrote:
> > Is there any compelling reason not to just drop the condition and do:
> >
> > current->thread.virtual_dr6 |= (dr6 & DR_STEP);
> >
> > unconditionally?
>
> Because why should it?
Because WINE does indeed rely on that. I'll go post a new version.
next prev parent reply other threads:[~2020-10-27 18:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 14:33 Kyle Huey
2020-10-26 15:55 ` Peter Zijlstra
2020-10-26 16:05 ` Peter Zijlstra
2020-10-26 16:14 ` Kyle Huey
2020-10-26 16:31 ` Peter Zijlstra
2020-10-26 16:55 ` Peter Zijlstra
2020-10-26 17:12 ` Kyle Huey
2020-10-26 17:17 ` Peter Zijlstra
2020-10-26 18:36 ` Kyle Huey
2020-10-26 23:30 ` Andy Lutomirski
2020-10-26 23:45 ` Andy Lutomirski
2020-10-27 8:15 ` Peter Zijlstra
2020-10-27 8:19 ` Peter Zijlstra
2020-10-27 18:00 ` Andy Lutomirski
2020-10-27 19:20 ` Peter Zijlstra
2020-10-27 9:08 ` Peter Zijlstra
2020-10-27 17:56 ` Peter Zijlstra [this message]
2020-10-26 16:08 ` Kyle Huey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201027175617.GF2651@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=alexandre.chartre@oracle.com \
--cc=boris.ostrovsky@oracle.com \
--cc=brgerst@gmail.com \
--cc=daniel.thompson@linaro.org \
--cc=frederic@kernel.org \
--cc=jgross@suse.com \
--cc=joel@joelfernandes.org \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=me@kylehuey.com \
--cc=mhiramat@kernel.org \
--cc=paulmck@kernel.org \
--cc=pbonzini@redhat.com \
--cc=pmladek@suse.com \
--cc=rocallahan@gmail.com \
--cc=rostedt@goodmis.org \
--cc=sean.j.christopherson@intel.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®