From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C0A1C4363A for ; Tue, 27 Oct 2020 18:24:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 594F92068E for ; Tue, 27 Oct 2020 18:24:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1827445AbgJ0SYI (ORCPT ); Tue, 27 Oct 2020 14:24:08 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:48058 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1827299AbgJ0SYB (ORCPT ); Tue, 27 Oct 2020 14:24:01 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kXTdS-003qce-1h; Tue, 27 Oct 2020 19:23:54 +0100 Date: Tue, 27 Oct 2020 19:23:54 +0100 From: Andrew Lunn To: Ivan Mikhaylov Cc: "David S . Miller" , Jakub Kicinski , Po-Yu Chuang , Joel Stanley , Benjamin Herrenschmidt , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org Subject: Re: [PATCH v2 2/2] net: ftgmac100: add handling of mdio/phy nodes for ast2400/2500 Message-ID: <20201027182354.GE904240@lunn.ch> References: <20201027144924.22183-1-i.mikhaylov@yadro.com> <20201027144924.22183-3-i.mikhaylov@yadro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201027144924.22183-3-i.mikhaylov@yadro.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 27, 2020 at 05:49:24PM +0300, Ivan Mikhaylov wrote: > phy-handle can't be handled well for ast2400/2500 which has an embedded > MDIO controller. Add ftgmac100_mdio_setup for ast2400/2500 and initialize > PHYs from mdio child node with of_mdiobus_register. > > Signed-off-by: Ivan Mikhaylov Please also update the binding documentation to indicate an MDIO node can be used. Andrew