mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Sean Christopherson <sean.j.christopherson@intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: Drop RDPID macro to discourage use of RDPID in the kernel
Date: Wed, 28 Oct 2020 09:54:05 +0100	[thread overview]
Message-ID: <20201028085405.GW2628@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20201027214532.1792-1-sean.j.christopherson@intel.com>

On Tue, Oct 27, 2020 at 02:45:32PM -0700, Sean Christopherson wrote:
> Drop the GAS-compatible RDPID macro as RDPID shouldn't be used in the
> kernel, excepting the vDSO, which handcodes RDPID in inline asm.  RDPID
> is unsafe in the kernel because KVM loads guest's TSC_AUX on VM-entry
> and may not restore the host's value until the CPU returns to userspace.
> 
> See commit 6a3ea3e68b8a ("x86/entry/64: Do not use RDPID in paranoid
> entry to accomodate KVM") for details.

Well, remove it because there is no (current) user, OK. But if there's a
compelling kernel side use for it, KVM can go suck rocks.

  reply	other threads:[~2020-10-28 21:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-27 21:45 Sean Christopherson
2020-10-28  8:54 ` Peter Zijlstra [this message]
2020-11-26 12:14 ` [tip: x86/cleanups] x86/asm: Drop unused RDPID macro tip-bot2 for Sean Christopherson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201028085405.GW2628@hirez.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=sean.j.christopherson@intel.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome