From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18600C56201 for ; Wed, 28 Oct 2020 22:13:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C677124724 for ; Wed, 28 Oct 2020 22:13:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730917AbgJ1WNG (ORCPT ); Wed, 28 Oct 2020 18:13:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:56460 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730827AbgJ1WMX (ORCPT ); Wed, 28 Oct 2020 18:12:23 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5ED0C24805; Wed, 28 Oct 2020 18:34:33 +0000 (UTC) Date: Wed, 28 Oct 2020 19:35:25 +0100 From: Greg Kroah-Hartman To: Christoph Hellwig Cc: Linus Torvalds , Al Viro , Linux Kernel Mailing List Subject: [PATCH] proc "single files": switch to ->read_iter Message-ID: <20201028183525.GB2957431@kroah.com> References: <20201027064832.GA209538@kroah.com> <20201027074911.GB29565@infradead.org> <20201027075541.GA24429@kroah.com> <20201027080745.GA31045@infradead.org> <20201027081420.GA30177@kroah.com> <20201027091725.GA42707@kroah.com> <20201027163213.GA25390@infradead.org> <20201028160011.GA2784447@kroah.com> <20201028183359.GA2957431@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201028183359.GA2957431@kroah.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Implement ->read_iter for all proc "single files" so that more bionic tests cases can pass when they call splice() on other fun files like /proc/version Signed-off-by: Greg Kroah-Hartman --- fs/proc/generic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/proc/generic.c b/fs/proc/generic.c index 2f9fa179194d..f81327673f49 100644 --- a/fs/proc/generic.c +++ b/fs/proc/generic.c @@ -621,7 +621,7 @@ static int proc_single_open(struct inode *inode, struct file *file) static const struct proc_ops proc_single_ops = { /* not permanent -- can call into arbitrary ->single_show */ .proc_open = proc_single_open, - .proc_read = seq_read, + .proc_read_iter = seq_read_iter, .proc_lseek = seq_lseek, .proc_release = single_release, }; -- 2.29.1