From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B748EC2D0A3 for ; Thu, 29 Oct 2020 10:13:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 639E220790 for ; Thu, 29 Oct 2020 10:13:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726435AbgJ2KNK (ORCPT ); Thu, 29 Oct 2020 06:13:10 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:49001 "EHLO out2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725809AbgJ2KNJ (ORCPT ); Thu, 29 Oct 2020 06:13:09 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id E9C945C0054; Thu, 29 Oct 2020 06:13:08 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Thu, 29 Oct 2020 06:13:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=rYsJB0Ni4Mc0mp+yF2jlzjmLYVg HkKIiuDaNCcantYE=; b=oeAe5bsVv0ivmMRlc57TUNPFb9FGgJdaOuX/s5CZ1af k8H9g4z8XIIGEvBr8FCP/dVveKU2hOs3kCoqd+OoKMYRivykzIL4tgUMzCOUW1/K Cy+/jPmbBtVJq/gEew7MO3yZIN8lqoX4ufBwiK0UIdllonYzJ9bDqiK4GHnQtU4V +alnD/33NzCs+DYUBMVW68d+hyrC5kaTEF4pDp1HxIEV7oWsp9hoA7GPQDLnv1ME DlcZOjLwUs5oBviiIMyHOwbiysykopZzdB+gXgU1xL8sViMGTk7LpX+k8UbmCAuB DwdocxK4471L9D7YrlVMLm2PLFWZ/DbQlGkE2XT/xeQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=rYsJB0 Ni4Mc0mp+yF2jlzjmLYVgHkKIiuDaNCcantYE=; b=p15BRphwQiBk9UNkkEEcj/ Zkqu2kJYL5Ya5YfNDOCu8jM7iCdCp6uV874ZjwL+xsD9lPIwXuAeO94TLTJYenEp CqKlhzEkIMHLbXd1WjDE0CJ2tqX9t1rj49KrPiQmj+AGiyUvnK/4ijsBCww4VSbo 7mOIt4ZgZMyIw7xr3on3sqd0yLrMneCCQo2UV3Q8vuJm7KZtvfEWZGLoVyR8E33j vtZ6gtuwyp6Pbnn10oscSQRVKUeJdLFo6C5zzRXkaCmtkcR9+UfBQO+h4tBQe1Bn S0aQeAuVsZiimuFgHwqQ5pDTrfjNJD5mYFunEQcv2rxW+bSinR8bA4HmQ/y/71cA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrleefgddugecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtth gvrhhnpeelkeeghefhuddtleejgfeljeffheffgfeijefhgfeufefhtdevteegheeiheeg udenucfkphepledtrdekledrieekrdejieenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id BA3E83280063; Thu, 29 Oct 2020 06:13:05 -0400 (EDT) Date: Thu, 29 Oct 2020 11:13:04 +0100 From: Maxime Ripard To: Matteo Scordino Cc: wens@csie.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Paul Kocialkowski , Icenowy Zheng Subject: Re: [PATCH 4/5] dt-bindings: arm: sunxi: add Elimo bindings Message-ID: <20201029101304.yja4m747pc62re34@gilmour.lan> References: <20201029022000.601913-1-matteo.scordino@gmail.com> <20201029022000.601913-5-matteo.scordino@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tfkoq4gmrgzotfz5" Content-Disposition: inline In-Reply-To: <20201029022000.601913-5-matteo.scordino@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --tfkoq4gmrgzotfz5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Thu, Oct 29, 2020 at 02:19:59AM +0000, Matteo Scordino wrote: > Document board compatible names for Elimo Engineering Impetus and Initium >=20 > Signed-off-by: Matteo Scordino > --- > Documentation/devicetree/bindings/arm/sunxi.yaml | 10 ++++++++++ > 1 file changed, 10 insertions(+) >=20 > diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documenta= tion/devicetree/bindings/arm/sunxi.yaml > index 0f23133672a3..55405809ec91 100644 > --- a/Documentation/devicetree/bindings/arm/sunxi.yaml > +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml > @@ -898,3 +898,13 @@ properties: > items: > - const: xunlong,orangepi-zero-plus2-h3 > - const: allwinner,sun8i-h3 > + > + - description: Elimo Engineering Impetus SoM > + items: > + - const: elimo,impetus > + - const: allwinner,sun8i-s3 > + > + - description: Elimo Engineering Initium > + items: > + - const: elimo,initium > + - const: allwinner,sun8i-s3 This should be ordered alphabetically, and most importantly, must match the ones you have in the DT. Here, we have kind of a mess already: the Lichee Zero+ uses ,sipeed,lichee-zero-plus, sochip,s3, allwinner,sun8i-v3, while the pinecube uses pine64,pinecube, allwinner,sun8i-s3 IIRC the S3 and V3 are pretty much the same SoCs, so the first one seems to make more sense to me, but then we should fix the pinecube. Maxime --tfkoq4gmrgzotfz5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX5qVsAAKCRDj7w1vZxhR xVVIAQDmDDS/BMkDYVHnPMF1XcIGfuy3Sko7fl3gm9DEwtOe2wD+N68SO2iPczRJ cwHDi17y9WbYOszqnj5SSrRBe3KFig4= =43AT -----END PGP SIGNATURE----- --tfkoq4gmrgzotfz5--