Re: [PATCH 2/4] misc/pvpanic: Add pvpanic driver framework

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3036 bytes --]

Hi Mihai,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on char-misc/char-misc-testing]
[also build test WARNING on linus/master v5.10-rc1 next-20201028]
[cannot apply to linux/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Mihai-Carabas/misc-pvpanic-preparing-for-pvpanic-driver-framework/20201029-204304
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git 3650b228f83adda7e5ee532e2b90429c03f7b9ec
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/d8f90ef175d20a5e55607c7dafea596286bb7a64
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Mihai-Carabas/misc-pvpanic-preparing-for-pvpanic-driver-framework/20201029-204304
        git checkout d8f90ef175d20a5e55607c7dafea596286bb7a64
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=xtensa 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/misc/pvpanic/pvpanic.c:54:5: warning: no previous prototype for 'pvpanic_add_device' [-Wmissing-prototypes]
      54 | int pvpanic_add_device(struct device *dev, struct resource *res)
         |     ^~~~~~~~~~~~~~~~~~
>> drivers/misc/pvpanic/pvpanic.c:81:6: warning: no previous prototype for 'pvpanic_remove_device' [-Wmissing-prototypes]
      81 | void pvpanic_remove_device(void)
         |      ^~~~~~~~~~~~~~~~~~~~~

vim +/pvpanic_add_device +54 drivers/misc/pvpanic/pvpanic.c

    53	
  > 54	int pvpanic_add_device(struct device *dev, struct resource *res)
    55	{
    56		struct platform_device *pdev;
    57		int ret;
    58	
    59		pdev = platform_device_alloc("pvpanic", -1);
    60		if (!pdev)
    61			return -ENOMEM;
    62	
    63		pdev->dev.parent = dev;
    64	
    65		ret = platform_device_add_resources(pdev, res, 1);
    66		if (ret)
    67			goto err;
    68	
    69		ret = platform_device_add(pdev);
    70		if (ret)
    71			goto err;
    72		pvpanic_data.pdev = pdev;
    73	
    74		return 0;
    75	err:
    76		platform_device_put(pdev);
    77		return ret;
    78	}
    79	EXPORT_SYMBOL_GPL(pvpanic_add_device);
    80	
  > 81	void pvpanic_remove_device(void)
    82	{
    83		platform_device_unregister(pvpanic_data.pdev);
    84		pvpanic_data.pdev = NULL;
    85	}
    86	EXPORT_SYMBOL_GPL(pvpanic_remove_device);
    87	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 66180 bytes --]