From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F978C56201 for ; Fri, 30 Oct 2020 07:20:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A16EB2151B for ; Fri, 30 Oct 2020 07:20:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604042434; bh=n1U/jwDmO28iTY1E7jx8zDWTnnrZD+VTD8qx7LukQsA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=XcPxP3K2chu34ql/XAq5eVPy5M/0d9FarJwcEbJbVYmMEFC+WJqQCuZshgWBwEXQk /M4+qm+JlI+i0GyPNL/6l1UHvoEiFOPLYO+oDFfki1naVtzCmeuygh6G1FGqRxOY9o MfooY2sF2fLfoSt6FHlBc+Byr7BhID8Om0hoMTPU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725931AbgJ3HUd (ORCPT ); Fri, 30 Oct 2020 03:20:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:47110 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725355AbgJ3HUd (ORCPT ); Fri, 30 Oct 2020 03:20:33 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C03032083B; Fri, 30 Oct 2020 07:20:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604042430; bh=n1U/jwDmO28iTY1E7jx8zDWTnnrZD+VTD8qx7LukQsA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YeSNZ615axN+XxQKryKAG80j38GWW+g2EUBngSwkILuznQyiw6BM5JpL46C86AP1s ig4sNYvcusQlBo0lHdWAWfjShC9IpIiSAiK5brycpeiawc9GYWrQRsRZGmW6D3MxNX EI9R7CORkH0tFymV0r/MBt1vduRdNevsmQa9b+5U= Date: Fri, 30 Oct 2020 08:21:18 +0100 From: Greg Kroah-Hartman To: Anand K Mistry Cc: linux-kernel@vger.kernel.org, "Rafael J. Wysocki" Subject: Re: [PATCH 1/1] debugfs: Add a helper to export atomic64_t values Message-ID: <20201030072118.GB1495407@kroah.com> References: <20201030070442.457739-1-amistry@google.com> <20201030180403.1.I9c36fd7a0e4d52e300c1004a0f6f2fc705e2b065@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201030180403.1.I9c36fd7a0e4d52e300c1004a0f6f2fc705e2b065@changeid> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 30, 2020 at 06:04:42PM +1100, Anand K Mistry wrote: > This mirrors support for exporting atomic_t values. > > Signed-off-by: Anand K Mistry > > --- > > fs/debugfs/file.c | 37 +++++++++++++++++++++++++++++++++++++ > include/linux/debugfs.h | 6 ++++++ > 2 files changed, 43 insertions(+) > > diff --git a/fs/debugfs/file.c b/fs/debugfs/file.c > index a768a09430c3..798bd3bdedec 100644 > --- a/fs/debugfs/file.c > +++ b/fs/debugfs/file.c > @@ -770,6 +770,43 @@ void debugfs_create_atomic_t(const char *name, umode_t mode, > } > EXPORT_SYMBOL_GPL(debugfs_create_atomic_t); > > +static int debugfs_atomic64_t_set(void *data, u64 val) > +{ > + atomic64_set((atomic64_t *)data, val); > + return 0; > +} > +static int debugfs_atomic64_t_get(void *data, u64 *val) > +{ > + *val = atomic64_read((atomic64_t *)data); > + return 0; > +} > +DEFINE_DEBUGFS_ATTRIBUTE(fops_atomic64_t, debugfs_atomic64_t_get, > + debugfs_atomic64_t_set, "%lld\n"); > +DEFINE_DEBUGFS_ATTRIBUTE(fops_atomic64_t_ro, debugfs_atomic64_t_get, NULL, > + "%lld\n"); > +DEFINE_DEBUGFS_ATTRIBUTE(fops_atomic64_t_wo, NULL, debugfs_atomic64_t_set, > + "%lld\n"); > + > +/** > + * debugfs_create_atomic64_t - create a debugfs file that is used to read and > + * write an atomic64_t value > + * @name: a pointer to a string containing the name of the file to create. > + * @mode: the permission that the file should have > + * @parent: a pointer to the parent dentry for this file. This should be a > + * directory dentry if set. If this parameter is %NULL, then the > + * file will be created in the root of the debugfs filesystem. > + * @value: a pointer to the variable that the file should read to and write > + * from. > + */ > +void debugfs_create_atomic64_t(const char *name, umode_t mode, > + struct dentry *parent, atomic64_t *value) > +{ > + debugfs_create_mode_unsafe(name, mode, parent, value, > + &fops_atomic64_t, &fops_atomic64_t_ro, > + &fops_atomic64_t_wo); > +} > +EXPORT_SYMBOL_GPL(debugfs_create_atomic64_t); > + > ssize_t debugfs_read_file_bool(struct file *file, char __user *user_buf, > size_t count, loff_t *ppos) > { > diff --git a/include/linux/debugfs.h b/include/linux/debugfs.h > index 851dd1f9a8a5..0fac84c53eab 100644 > --- a/include/linux/debugfs.h > +++ b/include/linux/debugfs.h > @@ -126,6 +126,8 @@ void debugfs_create_size_t(const char *name, umode_t mode, > struct dentry *parent, size_t *value); > void debugfs_create_atomic_t(const char *name, umode_t mode, > struct dentry *parent, atomic_t *value); > +void debugfs_create_atomic64_t(const char *name, umode_t mode, > + struct dentry *parent, atomic64_t *value); > struct dentry *debugfs_create_bool(const char *name, umode_t mode, > struct dentry *parent, bool *value); > > @@ -291,6 +293,10 @@ static inline void debugfs_create_atomic_t(const char *name, umode_t mode, > atomic_t *value) > { } > > +static inline void debugfs_create_atomic64_t(const char *name, umode_t mode, > + struct dentry *parent, atomic64_t *value) > +{ } > + > static inline struct dentry *debugfs_create_bool(const char *name, umode_t mode, > struct dentry *parent, > bool *value) Looks good, but where is the user of this code? I can't add new apis without a user. And are you _SURE_ you want to be using an atomic64_t in the first place? We are starting to reduce the "raw" usage of atomic variables as almost no one needs them, they should be using something else instead, or just a u64 as atomics are not needed for simple statistics. thanks, greg k-h