From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34CF8C00A89 for ; Fri, 30 Oct 2020 08:42:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AF6F3206D4 for ; Fri, 30 Oct 2020 08:42:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="2V6UYgLB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725974AbgJ3ImU (ORCPT ); Fri, 30 Oct 2020 04:42:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725355AbgJ3ImU (ORCPT ); Fri, 30 Oct 2020 04:42:20 -0400 Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01CA1C0613CF for ; Fri, 30 Oct 2020 01:42:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=mK1sKeQRc51Ss+CdNz/7onPx5BwriPwjLZ9pRTEesu0=; b=2V6UYgLBWG3/PqKfitYx5/qc/p PamQxEOIq1AGoq8oXkYPRWYUw2rezgQT83YfdLrwI9hUPi3EK3CX+q/4KF7QC6AzQpOjarjf7pQsK YkzmO5Aat2U8JdhJ95VjbydruuaRRrElnL3wWacOXce3ObJuoBJ89V6ANj51zMx6Cxhsjcbc5g81N JX90N/P3WN0fWwFIVo6hUQ+s+KiQXj2Ofb0V1l9BILwSMK7Cnm7pP5cL3rdZ3+2LNovFNX35U5+5E Ms08WVMInt0xh4J3+fQ8pPVo5sgbhYoT2kFA/NNFWDHXlwmgD6tygu2CrRFmLzsSXHGwi+/2LHBwZ iprh8QXQ==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kYPyK-0007L0-S2; Fri, 30 Oct 2020 08:41:21 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 266C93012C3; Fri, 30 Oct 2020 09:41:13 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id EDF4820DCC48D; Fri, 30 Oct 2020 09:41:12 +0100 (CET) Date: Fri, 30 Oct 2020 09:41:12 +0100 From: Peter Zijlstra To: Joel Fernandes Cc: Nishanth Aravamudan , Julien Desfossez , Tim Chen , Vineeth Pillai , Aaron Lu , Aubrey Li , Thomas Glexiner , LKML , Ingo Molnar , Kees Cook , Greg Kerr , Phil Auld , Valentin Schneider , Mel Gorman , Pawan Gupta , Paolo Bonzini , vineeth@bitbyteword.org, Chen Yu , Christian Brauner , Agata Gruza , Antonio Gomez Iglesias , graf@amazon.com, konrad.wilk@oracle.com, Dario Faggioli , Paul Turner , Steven Rostedt , Patrick Bellasi , =?utf-8?B?YmVuYmppYW5nKOiSi+W9qik=?= , Alexandre Chartre , James.Bottomley@hansenpartnership.com, OWeisse@umich.edu, Dhaval Giani , Junaid Shahid , Jesse Barnes , "Hyser,Chris" , Aubrey Li , Tim Chen Subject: Re: [PATCH v8 -tip 08/26] sched/fair: Snapshot the min_vruntime of CPUs on force idle Message-ID: <20201030084112.GX2628@hirez.programming.kicks-ass.net> References: <20201020014336.2076526-1-joel@joelfernandes.org> <20201020014336.2076526-9-joel@joelfernandes.org> <20201026124724.GT2611@hirez.programming.kicks-ass.net> <20201029182429.GA1844482@google.com> <20201029185933.GG2611@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 29, 2020 at 10:42:29PM -0400, Joel Fernandes wrote: > Forgot to ask, do you also need to do the task_vruntime_update() for > the unconstrained pick? Humm.. interesting case. Yes, however... since in that case the picks aren't synchronized it's a wee bit dodgy. I'll throw it on the pile together with SMT4. Also, I'm still hoping you can make this form work: https://lkml.kernel.org/r/20201026093131.GF2628@hirez.programming.kicks-ass.net (note that the put_prev_task() needs an additional rq argument) That's both simpler code and faster.