From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E3D9C4741F for ; Fri, 30 Oct 2020 09:17:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0B1B52087E for ; Fri, 30 Oct 2020 09:17:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726230AbgJ3JRr (ORCPT ); Fri, 30 Oct 2020 05:17:47 -0400 Received: from mga11.intel.com ([192.55.52.93]:46824 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725790AbgJ3JRp (ORCPT ); Fri, 30 Oct 2020 05:17:45 -0400 IronPort-SDR: rNr9pPVO4fdyMYGV2odKEToeKjjkRi85MkDljANnssPdrlkJdXuK6+Udcfu67iC2PbEpvtGWsZ 7785V4iMXNNA== X-IronPort-AV: E=McAfee;i="6000,8403,9789"; a="165085212" X-IronPort-AV: E=Sophos;i="5.77,432,1596524400"; d="scan'208";a="165085212" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Oct 2020 02:17:43 -0700 IronPort-SDR: w1IbwbktkrkgHUUjogQKipmETVnYkQgC1XD48IhM6Dy/nQ7FmnuoJJIAz/3IXbD//Qowa+xUcT qd4Pn+F5AuEA== X-IronPort-AV: E=Sophos;i="5.77,432,1596524400"; d="scan'208";a="361791463" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Oct 2020 02:17:38 -0700 Received: by paasikivi.fi.intel.com (Postfix, from userid 1000) id 9A48120736; Fri, 30 Oct 2020 11:17:36 +0200 (EET) Date: Fri, 30 Oct 2020 11:17:36 +0200 From: Sakari Ailus To: Krzysztof Kozlowski Cc: Pavel Machek , Mauro Carvalho Chehab , Lars-Peter Clausen , Tianshu Qiu , Dongchun Zhu , Shawn Tu , Ricardo Ribalda , Dave Stevenson , Manivannan Sadhasivam , Bingbu Cao , Rui Miguel Silva , Shunqian Zheng , Chiranjeevi Rapolu , Hyungwoo Yang , Wenyou Yang , Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH 01/25] media: i2c: imx214: simplify getting state container Message-ID: <20201030091736.GP26150@paasikivi.fi.intel.com> References: <20201029164239.84240-1-krzk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201029164239.84240-1-krzk@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, On Thu, Oct 29, 2020 at 05:42:15PM +0100, Krzysztof Kozlowski wrote: > The pointer to 'struct v4l2_subdev' is stored in drvdata via > v4l2_i2c_subdev_init() so there is no point of a dance like: > > struct i2c_client *client = to_i2c_client(struct device *dev) > struct v4l2_subdev *sd = i2c_get_clientdata(client); > > This allows to remove local variable 'client' and few pointer > dereferences. White at it, use 'dev' directly instead of 'imx214->dev'. > > Signed-off-by: Krzysztof Kozlowski I've applied the original set to my tree here: The status of the patches is generally indicated in Patchwork: "Under review" effectively, but perhaps confusingly, is also used to tell that the patch is in someone else's tree and on its way to Mauro's. IOW, it is not necessary to resend them. -- Regards, Sakari Ailus