From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Amelie Delaunay <amelie.delaunay@st.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
Fabrice Gasnier <fabrice.gasnier@st.com>
Subject: Re: [PATCH 1/1] usb: typec: add missing MODULE_DEVICE_TABLE() to stusb160x
Date: Fri, 30 Oct 2020 15:26:06 +0200 [thread overview]
Message-ID: <20201030132606.GD2333887@kuha.fi.intel.com> (raw)
In-Reply-To: <20201028151703.31195-1-amelie.delaunay@st.com>
On Wed, Oct 28, 2020 at 04:17:03PM +0100, Amelie Delaunay wrote:
> When stusb160x driver is built as a module, no modalias information is
> available, and it prevents the module to be loaded by udev.
> Add MODULE_DEVICE_TABLE() to fix this issue.
>
> Fixes: da0cb6310094 ("usb: typec: add support for STUSB160x Type-C controller family")
> Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/stusb160x.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/typec/stusb160x.c b/drivers/usb/typec/stusb160x.c
> index da7f1957bcb3..42076697e26c 100644
> --- a/drivers/usb/typec/stusb160x.c
> +++ b/drivers/usb/typec/stusb160x.c
> @@ -633,6 +633,7 @@ static const struct of_device_id stusb160x_of_match[] = {
> { .compatible = "st,stusb1600", .data = &stusb1600_regmap_config},
> {},
> };
> +MODULE_DEVICE_TABLE(of, stusb160x_of_match);
>
> static int stusb160x_probe(struct i2c_client *client)
> {
> --
> 2.17.1
--
heikki
prev parent reply other threads:[~2020-10-30 13:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 15:17 Amelie Delaunay
2020-10-30 13:26 ` Heikki Krogerus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201030132606.GD2333887@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=amelie.delaunay@st.com \
--cc=fabrice.gasnier@st.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome