From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B61D9C4363A for ; Fri, 30 Oct 2020 14:44:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5C1A82075E for ; Fri, 30 Oct 2020 14:44:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604069084; bh=hkBjTIMyTaX2dJRjqSGQ5hhGLfMUVMWI2P2FkxjzDgs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=c5jXw96M6jFUVEJwNXqTsE2cMb1L9xl0SwKEm3anlQOfv0d0/Xa+Qkf89kKdDWFx9 O+gJxapp81I9GJbB06P6yEjPyOvoji8wINiuuHgzgU/2GcefLrGEFLvRdrSyI1zZZW CtUTJjJQ9OCNPP34Vf6acTnDTt2rH/Ihva3HelXs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726674AbgJ3Oon (ORCPT ); Fri, 30 Oct 2020 10:44:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:39964 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725939AbgJ3Ool (ORCPT ); Fri, 30 Oct 2020 10:44:41 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0774020724; Fri, 30 Oct 2020 14:44:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604069080; bh=hkBjTIMyTaX2dJRjqSGQ5hhGLfMUVMWI2P2FkxjzDgs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GHKLcj0Eah8aX7EqX+kesrMqkk1+BVwFb5i89iAk4wNlYHLkYDvDxpNp1zzPbnp26 UdxF9uY2DMhRNuewZnsvpi5vbJKI+gD2pVyQiVgobAqNvwT9nkUzuntaLP99etLgUo mH8aHM0ZJC0siM3jTtZSWATW3B2YTWY1lSOyrrgw= Date: Fri, 30 Oct 2020 10:44:38 -0400 From: Sasha Levin To: Greg Kroah-Hartman Cc: Pavel Machek , linux-kernel@vger.kernel.org, akpm@linux-foundation.org, torvalds@linux-foundation.org, stable@vger.kernel.org, lwn@lwn.net, jslaby@suse.cz Subject: Re: Linux 4.19.153 Message-ID: <20201030144438.GH87646@sasha-vm> References: <160396822019115@kroah.com> <20201030082653.GA29475@amd> <20201030084915.GB1625087@kroah.com> <20201030091416.GA1759200@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20201030091416.GA1759200@kroah.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 30, 2020 at 10:14:16AM +0100, Greg Kroah-Hartman wrote: >On Fri, Oct 30, 2020 at 09:49:15AM +0100, Greg Kroah-Hartman wrote: >> On Fri, Oct 30, 2020 at 09:26:54AM +0100, Pavel Machek wrote: >> > Hi! >> > >> > > I'm announcing the release of the 4.19.153 kernel. >> > > >> > > All users of the 4.19 kernel series must upgrade. >> > > >> > > The updated 4.19.y git tree can be found at: >> > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-4.19.y >> > > and can be browsed at the normal kernel.org git web browser: >> > > https://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary >> > >> > Did something go seriously wrong here? >> > >> > The original 4.19.153-rc1 series had 264 patches. "powerpc/tau: Remove >> > duplicated set_thresholds() call" is 146/264 of the series, but it is >> > last one in 4.19.153 as released. "178/264 ext4: limit entries >> > returned when counting...", for example, is not present in >> > 4.19.153... as are others, for example "net: korina: cast KSEG0 >> > address to pointer in kfree". Looks like 118 or so patches are >> > missing. >> > >> > They are not in origin/queue/4.19, either. >> >> Wow, something did go wrong here, thanks for catching this. >> >> Let me dig and see what happened, the whole series did not apply, which >> makes me wonder if the same thing happened for other branches as well... >> >> thanks for checking up and finding this. >> >> Give me a bit... > >Ok, figure3d it out. > >Sasha changed a powerpc patch to build properly but didn't realize that >later powerpc patches would not apply because of that. I didn't run my >"apply all patches to make sure they are clean" script before doing the >release after he did that, so 'git quiltimport' failed when applying the >series at the place where the powerpc path failed to apply. > >My scripts don't check for the result of 'git quiltimport' being >successful or not (I don't even know if it return an error for this type >of thing), and just moved on in the release process. > >I'll go do a new 4.19 release with the rest of the patches missed here, >thank you for finding this. > >And I'll go make my release scripts more robust to failures like this as >well. > >thanks so much! You're right, sorry :( And thanks Pavel! -- Thanks, Sasha