From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8537C4741F for ; Fri, 30 Oct 2020 15:57:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 543672083B for ; Fri, 30 Oct 2020 15:57:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=sent.com header.i=@sent.com header.b="CM6maBmx"; dkim=temperror (0-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="XjsIw02X" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727045AbgJ3P5f (ORCPT ); Fri, 30 Oct 2020 11:57:35 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:54265 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726178AbgJ3P5c (ORCPT ); Fri, 30 Oct 2020 11:57:32 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 2AEAA5C02E3; Fri, 30 Oct 2020 11:57:31 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Fri, 30 Oct 2020 11:57:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sent.com; h=from :to:cc:subject:date:message-id:in-reply-to:references:reply-to :mime-version:content-type:content-transfer-encoding; s=fm1; bh= a+yV5AyyQgbkAmuRGp5Grqx+CnaA6i6TKDg6E8EnuoM=; b=CM6maBmxba6MD3gN Qh3zw0M8Aodzykt7peGyp7k/hIrMRoSl4FyRsvoZgLc5iOjVDs05mgSwWSVB3RnU FHLvhGZ8QPztxZ3oWCaeIpOZPWPEHEsTHeoYk7tHY4TDF3x0XLxMUFQ2cULSYdxz on7zYvowgLYsDo6wTr3SOIKJr+0V55ya+/HxrINLLieVhkKQGEyoe3n8LemVQ3ck k76+b5mmNeYjebN9Ef6Y3sbpPgmfzDS+HiARnQnY91NWj+SduiWXEHrPsUhkVowJ so/Sxk7BtDDyHw4qi7yUjut9k5Ymb7QEhiAgjkTB5FJfFuprNPqOCAG2KQigidNZ 0qgWvw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :reply-to:subject:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; bh=a+yV5AyyQgbkAmuRGp5Grqx+CnaA6 i6TKDg6E8EnuoM=; b=XjsIw02X52kdwL2SI7AqkUZsB2TNMfkrvT1ZSucW8u4vP 9PKkglNpAMYJOAWnOHqUCdcHxxIYY/67DCcN3Xjpy3T35LjkN2B4z+RxS+q/C0uo +6gds5HWz1ZooDha+wUdpT/VHGI+I2LeXv+blBPL10LsEnh4Dg/+PH52HPiallui xg0D+IkHHQVbLjlS1NoldygtcJvt0pqRKpAUX8pcmCetyDlWmraPrdHsvizrrbLH DvmXnX/Z9QZtPIqoxJ7goL93hTaTSsjYilQBwYBer0J95f1B/HSDJy0Np470chnU 1SLnleKf+vrEmVlYAZwJcHLRc+1CgOZ9rYaYmgsUw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrleehgdejkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkofgjfhhrgggtgfesthhqredtredtjeenucfhrhhomhepkghiucgj rghnuceoiihirdihrghnsehsvghnthdrtghomheqnecuggftrfgrthhtvghrnhepkefggf eljeefgeejtdethfehvdfgffdvfeefkeejtefghfetvdduffekgeeltedtnecukfhppedu vddrgeeirddutdeirdduieegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpe hmrghilhhfrhhomhepiihirdihrghnsehsvghnthdrtghomh X-ME-Proxy: Received: from nvrsysarch6.NVidia.COM (unknown [12.46.106.164]) by mail.messagingengine.com (Postfix) with ESMTPA id 45A85328005D; Fri, 30 Oct 2020 11:57:30 -0400 (EDT) From: Zi Yan To: Andrew Morton , linux-mm@kvack.org Cc: Yang Shi , Michal Hocko , Vlastimil Babka , Rik van Riel , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Zi Yan Subject: [PATCH v2 2/2] mm/compaction: stop isolation if too many pages are isolated and we have pages to migrate. Date: Fri, 30 Oct 2020 11:57:16 -0400 Message-Id: <20201030155716.3614401-2-zi.yan@sent.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201030155716.3614401-1-zi.yan@sent.com> References: <20201030155716.3614401-1-zi.yan@sent.com> Reply-To: Zi Yan MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Zi Yan In isolate_migratepages_block, if we have too many isolated pages and nr_migratepages is not zero, we should try to migrate what we have without wasting time on isolating. Fixes: 1da2f328fa64 (=E2=80=9Cmm,thp,compaction,cma: allow THP migration fo= r CMA allocations=E2=80=9D) Suggested-by: Vlastimil Babka Signed-off-by: Zi Yan Cc: --- mm/compaction.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/mm/compaction.c b/mm/compaction.c index 3e834ac402f1..4d237a7c3830 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -817,6 +817,10 @@ isolate_migratepages_block(struct compact_control *cc,= unsigned long low_pfn, * delay for some time until fewer pages are isolated */ while (unlikely(too_many_isolated(pgdat))) { + /* stop isolation if there are still pages not migrated */ + if (cc->nr_migratepages) + return 0; + /* async migration should just abort */ if (cc->mode =3D=3D MIGRATE_ASYNC) return 0; --=20 2.28.0