From: Mark Brown <broonie@kernel.org>
To: "Lu, Brent" <brent.lu@intel.com>
Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>,
"Rojewski, Cezary" <cezary.rojewski@intel.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Jason Yan <yanaijie@huawei.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Takashi Iwai <tiwai@suse.com>,
Jie Yang <yang.jie@linux.intel.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
"Nujella, Sathyanarayana" <sathyanarayana.nujella@intel.com>,
Fred Oh <fred.oh@linux.intel.com>,
"Wang, Rander" <rander.wang@intel.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
"Zhi, Yong" <yong.zhi@intel.com>
Subject: Re: [PATCH 2/2] ASoC: intel: sof_rt5682: Add quirk for Dooly
Date: Fri, 30 Oct 2020 17:01:56 +0000 [thread overview]
Message-ID: <20201030170156.GH4405@sirena.org.uk> (raw)
In-Reply-To: <DM6PR11MB3642F7AB13991ACF8A32B1DE97150@DM6PR11MB3642.namprd11.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 609 bytes --]
On Fri, Oct 30, 2020 at 04:44:17PM +0000, Lu, Brent wrote:
> , Brent Lu wrote:
> > Wondering if patch1 would be enough?
> Dooly has DMI family string " Google_Hatch" so the DMI quirk will overwrite the
> driver_data. I asked google but they prefer not removing this string so it seems to
> me that one extra DMI quirk is needed.
I think this needs at least a comment otherwise someone might come along
later and clean it up.
> The other way is using acpi_dev_present() in probe to update the quirk with correct
> codec setting. Which one do you think is better?
I don't have a strong opinion either way.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-10-30 17:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 6:36 [PATCH 0/2] Add rt1015 support to CML boards Brent Lu
2020-10-30 6:36 ` [PATCH 1/2] ASoC: intel: sof_rt5682: Add support for cml_rt1015_rt5682 Brent Lu
2020-10-30 6:36 ` [PATCH 2/2] ASoC: intel: sof_rt5682: Add quirk for Dooly Brent Lu
2020-10-30 15:32 ` Pierre-Louis Bossart
2020-10-30 16:44 ` Lu, Brent
2020-10-30 16:54 ` Pierre-Louis Bossart
2020-10-30 17:01 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201030170156.GH4405@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=brent.lu@intel.com \
--cc=cezary.rojewski@intel.com \
--cc=fred.oh@linux.intel.com \
--cc=guennadi.liakhovetski@linux.intel.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rander.wang@intel.com \
--cc=sathyanarayana.nujella@intel.com \
--cc=tiwai@suse.com \
--cc=yanaijie@huawei.com \
--cc=yang.jie@linux.intel.com \
--cc=yong.zhi@intel.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®