From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E7DEC388F2 for ; Sun, 1 Nov 2020 23:32:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1B47820678 for ; Sun, 1 Nov 2020 23:32:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604273538; bh=9W8D5IOm4zhgxQ2Hjs1ZEr2rk3CSHYivXx/5sW1fovw=; h=From:To:Cc:Subject:Date:List-ID:From; b=HS/OwD0ixuYBFOahaJtN1cwAAli6JjrHzmnLJIh1UoduI41doJtum67jTk0yarVUW bO6TxXyO/ZtkWlyullOROLTDV6RgviFMifByAXGEYzwINg9eBHLS1AShvLBzJ20+l7 ql2LESgfFDp/xJFzoLNVt18Nnp6kNTG3bVUB5H5Q= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727401AbgKAXbO convert rfc822-to-8bit (ORCPT ); Sun, 1 Nov 2020 18:31:14 -0500 Received: from us-smtp-delivery-44.mimecast.com ([207.211.30.44]:39024 "EHLO us-smtp-delivery-44.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727062AbgKAXbO (ORCPT ); Sun, 1 Nov 2020 18:31:14 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-247-wDTTpkwsND-Vvdlwn1gjXg-1; Sun, 01 Nov 2020 18:31:09 -0500 X-MC-Unique: wDTTpkwsND-Vvdlwn1gjXg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 16468107AFD1; Sun, 1 Nov 2020 23:31:07 +0000 (UTC) Received: from krava.redhat.com (unknown [10.40.192.101]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3018462A14; Sun, 1 Nov 2020 23:31:04 +0000 (UTC) From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: lkml , Peter Zijlstra , Ingo Molnar , Mark Rutland , Namhyung Kim , Alexander Shishkin , Michael Petlan , Ian Rogers , Stephane Eranian Subject: [PATCH 1/2] perf tools: Initialize output buffer in build_id__sprintf Date: Mon, 2 Nov 2020 00:31:02 +0100 Message-Id: <20201101233103.3537427-1-jolsa@kernel.org> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jolsa@kernel.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: kernel.org Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset=WINDOWS-1252 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We display garbage for undefined build_id objects, because we don't initialize the output buffer. Signed-off-by: Jiri Olsa --- tools/perf/util/build-id.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/perf/util/build-id.c b/tools/perf/util/build-id.c index 8763772f1095..6b410c3d52dc 100644 --- a/tools/perf/util/build-id.c +++ b/tools/perf/util/build-id.c @@ -102,6 +102,8 @@ int build_id__sprintf(const struct build_id *build_id, char *bf) const u8 *raw = build_id->data; size_t i; + bf[0] = 0x0; + for (i = 0; i < build_id->size; ++i) { sprintf(bid, "%02x", *raw); ++raw; -- 2.26.2