From: kernel test robot <lkp@intel.com>
To: Divya Bharathi <divya.bharathi@dell.com>
Cc: kbuild-all@lists.01.org, Hans de Goede <hdegoede@redhat.com>,
Mario Limonciello <mario.limonciello@dell.com>,
Prasanth KSR <prasanth.ksr@dell.com>,
Mark Gross <mgross@linux.intel.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [RFC PATCH linux-platform-drivers-x86] platform/x86: po_is_pass_set can be static
Date: Mon, 2 Nov 2020 13:15:36 +0800 [thread overview]
Message-ID: <20201102051536.GA97836@d07872ef61d7> (raw)
In-Reply-To: <202011021321.WZVoG5Tr-lkp@intel.com>
Fixes: e8a60aa7404b ("platform/x86: Introduce support for Systems Management Driver over WMI for Dell Systems")
Signed-off-by: kernel test robot <lkp@intel.com>
---
passobj-attributes.c | 14 +++++++-------
sysman.c | 2 +-
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c b/drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c
index e6199fb748a95a..81562b178c9cdd 100644
--- a/drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c
+++ b/drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c
@@ -35,7 +35,7 @@ static ssize_t is_enabled_show(struct kobject *kobj, struct kobj_attribute *attr
return ret;
}
-struct kobj_attribute po_is_pass_set =
+static struct kobj_attribute po_is_pass_set =
__ATTR_RO(is_enabled);
static ssize_t current_password_store(struct kobject *kobj,
@@ -67,7 +67,7 @@ static ssize_t current_password_store(struct kobject *kobj,
return count;
}
-struct kobj_attribute po_current_password =
+static struct kobj_attribute po_current_password =
__ATTR_WO(current_password);
static ssize_t new_password_store(struct kobject *kobj,
@@ -96,15 +96,15 @@ static ssize_t new_password_store(struct kobject *kobj,
return ret ? ret : count;
}
-struct kobj_attribute po_new_password =
+static struct kobj_attribute po_new_password =
__ATTR_WO(new_password);
attribute_n_property_show(min_password_length, po);
-struct kobj_attribute po_min_pass_length =
+static struct kobj_attribute po_min_pass_length =
__ATTR_RO(min_password_length);
attribute_n_property_show(max_password_length, po);
-struct kobj_attribute po_max_pass_length =
+static struct kobj_attribute po_max_pass_length =
__ATTR_RO(max_password_length);
static ssize_t mechanism_show(struct kobject *kobj, struct kobj_attribute *attr,
@@ -113,7 +113,7 @@ static ssize_t mechanism_show(struct kobject *kobj, struct kobj_attribute *attr,
return sprintf(buf, "password\n");
}
-struct kobj_attribute po_mechanism =
+static struct kobj_attribute po_mechanism =
__ATTR_RO(mechanism);
static ssize_t role_show(struct kobject *kobj, struct kobj_attribute *attr,
@@ -126,7 +126,7 @@ static ssize_t role_show(struct kobject *kobj, struct kobj_attribute *attr,
return -EIO;
}
-struct kobj_attribute po_role =
+static struct kobj_attribute po_role =
__ATTR_RO(role);
static struct attribute *po_attrs[] = {
diff --git a/drivers/platform/x86/dell-wmi-sysman/sysman.c b/drivers/platform/x86/dell-wmi-sysman/sysman.c
index 3842575a6c189f..c6862c3e9b491a 100644
--- a/drivers/platform/x86/dell-wmi-sysman/sysman.c
+++ b/drivers/platform/x86/dell-wmi-sysman/sysman.c
@@ -255,7 +255,7 @@ static ssize_t wmi_sysman_attr_store(struct kobject *kobj, struct attribute *att
return ret;
}
-const struct sysfs_ops wmi_sysman_kobj_sysfs_ops = {
+static const struct sysfs_ops wmi_sysman_kobj_sysfs_ops = {
.show = wmi_sysman_attr_show,
.store = wmi_sysman_attr_store,
};
prev parent reply other threads:[~2020-11-02 5:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-02 5:15 [linux-platform-drivers-x86:for-next 7/7] drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c:38:23: sparse: sparse: symbol 'po_is_pass_set' was not declared. Should it be kernel test robot
2020-11-02 5:15 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201102051536.GA97836@d07872ef61d7 \
--to=lkp@intel.com \
--cc=divya.bharathi@dell.com \
--cc=hdegoede@redhat.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@dell.com \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=prasanth.ksr@dell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®