From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8710C388F2 for ; Mon, 2 Nov 2020 16:09:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A04C022258 for ; Mon, 2 Nov 2020 16:09:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604333395; bh=KjbbvUyNRfIy/F798a/hF/fB5rEyDicNk6ioLYZH98g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=JyRGu4Iuvpg3PCnKCcZ9ry7htpO25onSpPL656HO78RLig973L8blHB44+1wlhN8+ QUk1OEXn1gkKNYBF0tZK4THbghPbMEwc3cKo54nj/O7Rc7nAgy3npP0/xRtYwBRwK4 BGtylp05Wpl5dtGGOIWkIsQH70FGsj6Fm1OLmSRk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727041AbgKBQJy (ORCPT ); Mon, 2 Nov 2020 11:09:54 -0500 Received: from mail.kernel.org ([198.145.29.99]:53526 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726945AbgKBQJw (ORCPT ); Mon, 2 Nov 2020 11:09:52 -0500 Received: from google.com (unknown [104.132.1.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EFE7122277; Mon, 2 Nov 2020 16:09:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604333392; bh=KjbbvUyNRfIy/F798a/hF/fB5rEyDicNk6ioLYZH98g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ltfOBxu85u043HltVYcOv7N/cagykHReMo1d5xjIWgxmkAW1neFILugRAigchLKYy XiUB8T76w27vWSGkQocoKqm+sS/KJT7OONgPFxTkDLYgtxTujn+79cCnb3/KsPMmlm dg69SJDU8LH+QRkGaKC0rco7g0lSF+Sjj2BzdBiI= Date: Mon, 2 Nov 2020 08:09:50 -0800 From: Jaegeuk Kim To: Chao Yu Cc: Robin Hsu , linux-f2fs-devel@lists.sourceforge.net, chao@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [f2fs-dev] [PATCH 1/1] f2fs-toos:fsck.f2fs Fix bad return value Message-ID: <20201102160950.GB529594@google.com> References: <20201026094000.1500425-1-robinhsu@google.com> <299c9027-e137-83ff-b2ba-8af07144a488@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <299c9027-e137-83ff-b2ba-8af07144a488@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/28, Chao Yu wrote: > On 2020/10/26 17:40, Robin Hsu via Linux-f2fs-devel wrote: > > 'ret' should not have been used here: otherwise, it would be wrongly used > > as the error code and then be returned from main(). > > > > Signed-off-by: Robin Hsu > > BTW, how about changing 'ret = EXIT_ERR_CODE' to > 'ret = FSCK_ERRORS_LEFT_UNCORRECTED', it's not critical though. > > Reviewed-by: Chao Yu I think it'd be good to go as is for now. :) > > Thanks,